Skip to content

[workspace] Improve context on qhull tag lock#24650

Merged
jwnimmer-tri merged 1 commit into
RobotLocomotion:masterfrom
tyler-yankee:qhull-regex
Jun 22, 2026
Merged

[workspace] Improve context on qhull tag lock#24650
jwnimmer-tri merged 1 commit into
RobotLocomotion:masterfrom
tyler-yankee:qhull-regex

Conversation

@tyler-yankee

@tyler-yankee tyler-yankee commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

For context, see https://github.com/qhull/qhull/tags. Tested by temporarily reverting to 2020.1, and additional manual testing with made-up newer versions e.g. 2026.1.

Follow-up from #24593.


This change is Reviewable

@tyler-yankee tyler-yankee left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+a:@mwoehlke-kitware for feature review, please.

@tyler-yankee made 1 comment.
Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on mwoehlke-kitware).

@mwoehlke-kitware mwoehlke-kitware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@mwoehlke-kitware made 1 comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers.

@tyler-yankee tyler-yankee left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+a:@jwnimmer-tri for platform review per schedule, please.

@tyler-yankee reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform) (waiting on jwnimmer-tri and mwoehlke-kitware).

@jwnimmer-tri jwnimmer-tri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jwnimmer-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),mwoehlke-kitware (waiting on mwoehlke-kitware).

@jwnimmer-tri jwnimmer-tri merged commit 8ffde94 into RobotLocomotion:master Jun 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low release notes: none This pull request should not be mentioned in the release notes

Development

Successfully merging this pull request may close these issues.

3 participants