Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions qiskit_addon_cutting/utils/transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,11 @@ def _separate_instructions_by_partition(
}

for i, inst in enumerate(circuit.data):
# A zero-qubit global-phase instruction spans no partition, so it
# cannot be assigned to any subcircuit; skip it.
if inst.operation.name == "global_phase":
continue

# Collect the partition labels spanned by the instruction
partitions_spanned = set()
for qubit in inst.qubits:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
fixes:
- |
Fixed an ``AssertionError`` raised by ``separate_circuit()`` (and, in turn,
``partition_problem()``) when the input circuit contained a zero-qubit
``global_phase`` instruction. Such an instruction spans no partition, so it
is now skipped when assigning operations to subcircuits.
17 changes: 16 additions & 1 deletion test/utils/test_transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
QuantumCircuit,
CircuitInstruction,
)
from qiskit.circuit.library import efficient_su2, Measure
from qiskit.circuit.library import efficient_su2, Measure, GlobalPhaseGate
from qiskit.circuit.library.standard_gates import RZZGate

from qiskit_addon_cutting import partition_circuit_qubits
Expand Down Expand Up @@ -357,6 +357,21 @@ def test_separate_circuit(self):
subcircuits[i].data[j].operation.name, inst.operation.name
)

with self.subTest("Zero-qubit global-phase instruction is dropped"):
qc = QuantumCircuit(2)
qc.append(GlobalPhaseGate(0.5), [])
qc.x(0)
qc.y(1)

subcircuits = separate_circuit(qc, "AB").subcircuits

self.assertEqual(
["x"], [inst.operation.name for inst in subcircuits["A"].data]
)
self.assertEqual(
["y"], [inst.operation.name for inst in subcircuits["B"].data]
)

with self.subTest("Bad partition labels"):
circuit = QuantumCircuit(2)
partition_labels = "ABB"
Expand Down