Skip zero-qubit global_phase instructions during circuit separation#817
Merged
Conversation
d708a80 to
696d140
Compare
696d140 to
e233650
Compare
garrison
approved these changes
Jun 22, 2026
garrison
left a comment
Member
There was a problem hiding this comment.
LGTM. Thank you for this contribution.
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
separate_circuit()(and thereforepartition_problem()) raised anAssertionErrorwhen the input circuit contained a zero-qubitglobal_phaseinstruction.Details
A
global_phaseinstruction acts on no qubits, so it spans no partition and cannot be assigned to a subcircuit. It is now skipped while assigning operations to subcircuits. Global phase does not affect the expectation values the cutting workflow reconstructs, so dropping it during separation is safe.Tests
pytest test/utils/test_transforms.py test/test_cutting_decomposition.pyruff checkandblack --checkon the changed filesFixes #762