Conversation
zzylol
force-pushed
the
fix/type-logical-candidates-upfront
branch
from
September 30, 2026 15:02
7613ddf to
2ce2942
Compare
Execute only typed ExternalExact requests. Reject retired logical exact leaves before preparation and keep remote exact composition tests on the installed request boundary. Regression failed before and passed afterward; all 12 exact_subqueries tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve YAML enum tags before decoding, while keeping JSON numeric binding keys valid. Build a temporary decoded DAG/family lookup for each validation or installation pass and reuse installed family maps during revision recovery. Derive non-TopK item labels from the same Planner update as runtime. Refresh ownership and v2 deployment-only materialization documentation. Validation: YAML regression fails on the original JSON buffer; 99 shared-type tests pass after the fix. Nonempty JSON/YAML DAG roundtrip and keyed-label regressions pass. Independent review by mixed_placement agent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
fix/type-logical-candidates-upfront
branch
from
September 30, 2026 15:17
2ce2942 to
aaa7876
Compare
zzylol
marked this pull request as ready for review
September 30, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #810.
Why
Installed-plan transport and metadata lookup still had inconsistencies after #806, and obsolete exact-subquery execution remained in the data plane.
What
Preserve YAML enum tags and JSON DAG keys, derive keyed item labels consistently, reuse decoded DAGs within each validation/installation pass, and use indexed installed-state metadata during ingestion and recovery. Remove legacy exact-subquery execution and refresh the deployment design docs.
Before this PR
A typed YAML plan could fail decoding, keyed non-top-k OTLP state could omit its item label, and repeated metadata lookups decoded each DAG again. Legacy exact leaves still entered runtime execution.
After this PR
Nonempty plans round-trip through JSON and YAML; installed item labels match runtime interpretation. A temporary decoded lookup preserves the installed plan's Send/Sync contract while avoiding repeat decoding. Legacy exact leaves are rejected before execution; typed ExternalExact requests retain the supported path.
Validation
Fail-before/pass-after regressions cover YAML transport, keyed item labels, and legacy exact rejection, plus nonempty JSON/YAML DAG round trips. Independent review completed. On head
aaa78769with Plannera049a3b: fmt; workspace/all-target clippy with warnings denied; workspace library tests; all control-plane tests; and all 29 compatibility process tests pass (121.32 s), including warm successive evaluations and durable multi-source maintenance.🤖 Generated with Claude Code