Skip to content

Pin mixed revisions between stored window boundaries - #808

Open
zzylol wants to merge 1 commit into
fix/type-logical-candidates-upfrontfrom
fix/placement-pricing-lag
Open

zzylol wants to merge 1 commit into
fix/type-logical-candidates-upfrontfrom
fix/placement-pricing-lag

Conversation

@zzylol

@zzylol zzylol commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #811.

Why

Remote-write revision pinning required a stored window ending exactly at the query evaluation timestamp. Mixed queries between window boundaries fell back before bounded-lag execution could select the latest complete window.

What

Pin one compatible revision with complete stored windows within each mixed binding's configured lag bound (default one slide). Retain only admitted windows; stored-only queries still require exact interval coverage.

Before this PR

A mixed query evaluated three seconds after a window boundary fell back despite a complete stored window within its lag bound.

After this PR

The query fetches raw input at its requested timestamp, combines it with the admitted stored window, and reports the three-second lag. Incomplete newer windows do not shadow complete older windows.

Validation

  • The new off-grid process regression failed before the fix and passes after it.
  • Formatting, workspace clippy, workspace library tests, control-plane tests, and all 30 compatibility process tests pass.
  • Independent agent review checked revision consistency, group completeness, lag bounds, and preservation of exact stored-only reads; no blockers remained.

🤖 Generated with Claude Code

Final stack validation at #809 / Planner a049a3b: formatting, clippy, workspace library tests, all control-plane tests, and all 30 process tests pass (122.91s).

@zzylol
zzylol marked this pull request as draft September 30, 2026 15:03
@zzylol
zzylol force-pushed the fix/placement-pricing-lag branch from 8c8aeda to e899d10 Compare September 30, 2026 15:04
@zzylol
zzylol changed the base branch from feat/per-state-mixed-placement to fix/type-logical-candidates-upfront September 30, 2026 15:04
@zzylol
zzylol force-pushed the fix/type-logical-candidates-upfront branch from 2ce2942 to aaa7876 Compare September 30, 2026 15:17
Select the newest complete stored window from one compatible revision at off-grid evaluation times, while retaining exact coverage for stored-only queries. The new +3s process regression failed before the fix and passes afterward.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zzylol
zzylol force-pushed the fix/placement-pricing-lag branch from e899d10 to ec8786e Compare September 30, 2026 15:18
@zzylol
zzylol marked this pull request as ready for review September 30, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant