Conversation
Replace the UnivMon shim and private serde mirrors with Planner kernel accessors. Preserve sampling metadata through storage and direct readouts, reject retired formats, and validate malformed deltas before in-place updates. Repin Planner integration without changing sketchlib revisions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Select once over identity-typed logical roots; remove the compile-error-triggered retry. Preserve canonical frontend roots for exact routing and native candidate enumeration. Cover first-selection arithmetic, first-forest sort deployment, shared fingerprints, and warm shared workloads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve the kernel sampling envelope through window reconstruction and durable recovery instead of decoding it as raw sketchlib bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use the hypothetical installed window layout for retained native candidates, including after upfront series typing exposes additional physical candidates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The label_replace implementation adds an edge to the already locked regex package. Preserve every dependency version and sketchlib revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve the priced physical realization instead of recompiling it after window preparation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restore two-source derived maintenance after upfront identity typing; preserve all dependency versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
marked this pull request as ready for review
September 30, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #806.
Why
The backend must use Planner-owned computation and preserve sampling metadata through stored-state reads. The integrated Planner now also types series identity before physical selection and compiles the remaining requested PromQL shapes.
What
Remove the UnivMon shim and private codec mirrors; use validated Planner kernel accessors and in-place delta updates. Version sampled and exact payloads, including durable frame tags, and reject retired formats. Type candidates before selection, remove reselection, retain safe whole-query fallback for unbindable candidates, and price native timing using its installed windows.
Pin Planner integration
a049a3b6c17cee4c51c79e478799b32280a7d71d. Lock changes preserve every dependency version and sketchlib revision; the new Planner label_replace dependency requires one reference to the already locked regex package.Before this PR
Sampled edge frames were rejected; stored payloads omitted sampling metadata; duplicate backend code implemented UnivMon and decoded private kernel layouts. Candidate selection needed a typed retry.
After this PR
Sampled frames retain their probability through updates, window readout, persistence, and recovery. Old formats fail explicitly. Logical candidates carry series identity up front and execution stays with Planner kernels and physical programs.
Review dependency
Open PR #791 overlaps the SDS ownership and stored-state decoding changes already carried by #793/#805. It uses an older Planner pin and should be reconciled before either overlapping route is merged. This PR does not merge either route.
Validation
Independent review completed for codec, delta atomicity, upfront typing, native pricing, and stored-frame routing. All required checks passed at the final Planner pin:
Regressions were established before the fixes. Planner's corresponding full workspace validation also passed.
🤖 Generated with Claude Code