Skip to content

fix(manager): remove obsolete Contact Us translation keys#2755

Merged
ohnorobo merged 1 commit into
masterfrom
laplante/remove-contact-us-manager-strings
Apr 27, 2026
Merged

fix(manager): remove obsolete Contact Us translation keys#2755
ohnorobo merged 1 commit into
masterfrom
laplante/remove-contact-us-manager-strings

Conversation

@ohnorobo

@ohnorobo ohnorobo commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Follow up to #2754 removing unused strings

Strips nav-contact-us and the contact-view-* keys from all locale files. Follow-up to removing the Contact Us dialog flow in the manager.

@ohnorobo ohnorobo force-pushed the laplante/remove-contact-us-manager-strings branch from fef8585 to fd95fcd Compare April 22, 2026 09:51
@github-actions github-actions Bot added size/XXL and removed size/XL labels Apr 22, 2026
@ohnorobo ohnorobo force-pushed the laplante/remove-contact-us-manager branch from c60fa39 to 9109084 Compare April 22, 2026 09:51
@ohnorobo ohnorobo marked this pull request as ready for review April 22, 2026 10:14
@ohnorobo ohnorobo requested a review from a team as a code owner April 22, 2026 10:14
@ohnorobo ohnorobo requested a review from fortuna April 22, 2026 10:14
@greptile-apps

greptile-apps Bot commented Apr 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes 11 obsolete i18n translation keys (nav-contact-us and contact-view-*) from all 66 locale files under server_manager/messages/, as a follow-up to PR #2754 which removed the Contact Us dialog flow from the manager UI.

  • Removes 11 keys (nav-contact-us, contact-view-intro, contact-view-issue, contact-view-issue-*, contact-view-exit-*, contact-view-open-ticket) from all 66 language locale files
  • Also removes these keys from master_messages.json (the source-of-truth descriptor file)
  • Fixes a missing trailing newline in several locale files (e.g. af.json, am.json) as a side effect
  • Verified: no remaining references to the removed keys exist anywhere in server_manager/ (HTML, TS, JS, or JSON), confirming the removal is safe
  • Note: client/web/messages/ locale files also contain contact-view-* keys but those are for the separate client app and are not affected by this PR

Confidence Score: 5/5

Safe to merge — purely removes dead translation keys with no remaining code references.

The change is mechanical and low-risk: it deletes keys that are no longer referenced by any server_manager code (verified via search), from all locale files consistently, including the master_messages.json source file. No logic changes, no API surface changes, no remaining references to the deleted keys.

No files require special attention.

Important Files Changed

Filename Overview
server_manager/messages/master_messages.json Source-of-truth descriptor file: all contact-view-* and nav-contact-us entries correctly removed.
server_manager/messages/en.json English base locale: 11 obsolete keys cleanly removed with no remaining references.
server_manager/messages/af.json Afrikaans locale: keys removed; trailing newline also fixed as a side effect.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR #2754: Remove Contact Us dialog flow\nfrom Manager UI source code] --> B[Orphaned i18n keys remain\nin all 66 locale JSON files]
    B --> C[This PR #2755: Remove obsolete keys]
    C --> D[master_messages.json\nnav-contact-us removed\ncontact-view-* removed]
    C --> E[66 locale files\nnav-contact-us removed\ncontact-view-* removed]
    D & E --> F[No dangling key references\nin server_manager/]
    G[client/web/messages/\ncontact-view-* keys] --> H[Untouched — separate client app\nhas its own i18n scope]
Loading

Reviews (1): Last reviewed commit: "remove obsolete Contact Us translation k..." | Re-trigger Greptile

Base automatically changed from laplante/remove-contact-us-manager to master April 23, 2026 11:16
@ohnorobo ohnorobo force-pushed the laplante/remove-contact-us-manager-strings branch from fd95fcd to 47933e1 Compare April 23, 2026 11:17
@github-actions github-actions Bot added size/XL and removed size/XXL labels Apr 23, 2026
@ohnorobo ohnorobo enabled auto-merge (squash) April 23, 2026 11:18
@ohnorobo

Copy link
Copy Markdown
Contributor Author

@fortuna I still need your approval here as a follow up to #2754

Strips nav-contact-us and the contact-view-* keys from all locale
files. Follow-up to removing the Contact Us dialog flow in the manager.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ohnorobo ohnorobo force-pushed the laplante/remove-contact-us-manager-strings branch from 47933e1 to ac8b3bb Compare April 27, 2026 08:44
@ohnorobo ohnorobo merged commit fd02690 into master Apr 27, 2026
23 checks passed
@ohnorobo ohnorobo deleted the laplante/remove-contact-us-manager-strings branch April 27, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants