Skip to content

fix(manager): replace manager contact us with just a sentry feedback flow#2754

Merged
ohnorobo merged 1 commit into
masterfrom
laplante/remove-contact-us-manager
Apr 23, 2026
Merged

fix(manager): replace manager contact us with just a sentry feedback flow#2754
ohnorobo merged 1 commit into
masterfrom
laplante/remove-contact-us-manager

Conversation

@ohnorobo

@ohnorobo ohnorobo commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Replace the "Contact Us" dialog tree with just the "Feedback" dialog in the manager. That still uses Sentry.captureFeedback.

Currently we give the strong impression that users can get in contact with us directly for support. Since we no longer offer this it's best to remove the meandering dialog flow and just offer a Feedback option.

Should be followed by #2755, but I split that into its own PR to make this more readable.

Feedback flow (tested via npm run action server_manager/www/start):
Screenshot 2026-04-22 at 11 35 21
Screenshot 2026-04-22 at 11 35 47
Screenshot 2026-04-22 at 11 36 45

TODO: also do this for the client once #2739 is merged.

@ohnorobo ohnorobo changed the title replace manager contact us with just a sentry feedback flow fix(manager): replace manager contact us with just a sentry feedback flow Apr 22, 2026
Replaces the multi-step "Contact Us" dialog with the existing simple
Feedback dialog, which submits via Sentry.captureFeedback. Email/ticket
support is no longer offered, so the elaborate triage wizard is dead
weight. Also drops the now-unused contactView feature flag and the
success/error toast helpers that only the Contact Us flow wired up.

Adds a TODO on the cross-platform client's contact-us view noting it
should be removed entirely once #2739 merges.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ohnorobo ohnorobo force-pushed the laplante/remove-contact-us-manager branch from c60fa39 to 9109084 Compare April 22, 2026 09:51
@ohnorobo ohnorobo marked this pull request as ready for review April 22, 2026 10:14
@ohnorobo ohnorobo requested a review from a team as a code owner April 22, 2026 10:14
@ohnorobo ohnorobo requested a review from fortuna April 22, 2026 10:14
@greptile-apps

greptile-apps Bot commented Apr 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR simplifies the server manager's feedback flow by removing the multi-step "Contact Us" dialog tree (outline-contact-us-dialog, outline-support-form) and replacing it unconditionally with the existing simpler outline-feedback-dialog that submits via Sentry.captureFeedback. The contactView feature flag and its conditional rendering logic are fully removed.

Key changes:

  • outline-contact-us-dialog.ts and outline-support-form.ts are deleted; no remaining references exist in the codebase.
  • app-root.ts: the contactView feature flag, both <template is=\"dom-if\"> dialog branches, the nav-label conditional, and the now-unused showContactSuccessToast/showContactErrorToast methods are all removed. A single <outline-feedback-dialog id=\"feedbackDialog\"> replaces both.
  • client/web/views/contact_view/index.ts: a TODO comment is added pointing to the follow-up PR (chore(client): use Sentry User Feedback API for client feedback #2739) to apply the same simplification to the client.
  • The nav-contact-us localization key is now unused in the manager (the client-side removal is deferred to PR chore(client): use Sentry User Feedback API for client feedback #2739). The key remains in all message files but is harmless dead weight for now.

Confidence Score: 5/5

Safe to merge — a clean, well-scoped removal of a deprecated dialog with no remaining broken references.

All references to the deleted components are gone, the feature flag and its conditional branches are fully removed, the replacement dialog was already in use and proven, and the author tested the flow manually. The only leftover is the now-unused nav-contact-us string in message files, which is harmless and deferred to a follow-up cleanup.

No files require special attention.

Important Files Changed

Filename Overview
server_manager/www/ui_components/app-root.ts Removes contactView feature flag, its two conditional dialog templates, and the now-unused success/error toast handlers; replaces them with a single unconditional outline-feedback-dialog. The simplification is correct and complete.
server_manager/www/ui_components/outline-contact-us-dialog.ts Entire file deleted; no remaining references exist in the codebase. Deletion is clean.
server_manager/www/ui_components/outline-support-form.ts Entire file deleted; no remaining references exist in the codebase. Deletion is clean.
client/web/views/contact_view/index.ts Only change is a TODO comment linking to the follow-up PR (#2739) to remove this view from the client side. No functional changes.

Sequence Diagram

sequenceDiagram
    participant User
    participant AppRoot
    participant FeedbackDialog as outline-feedback-dialog
    participant AppTS as app.ts (SubmitFeedback handler)
    participant Sentry

    User->>AppRoot: Tap "Feedback" (nav-feedback)
    AppRoot->>FeedbackDialog: open()
    User->>FeedbackDialog: Fill in form & submit
    FeedbackDialog->>AppRoot: fire('SubmitFeedback', detail)
    AppRoot->>AppTS: event propagates
    AppTS->>Sentry: captureFeedback({ message, email, tags })
    AppTS->>AppRoot: showNotification('notification-feedback-thanks')
Loading

Reviews (1): Last reviewed commit: "remove Contact Us dialog flow from the m..." | Re-trigger Greptile

@fortuna fortuna left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if we are still showing the toast

Comment thread server_manager/www/ui_components/app-root.ts
@ohnorobo ohnorobo merged commit c6c715f into master Apr 23, 2026
47 checks passed
@ohnorobo ohnorobo deleted the laplante/remove-contact-us-manager branch April 23, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants