fix(tui): clarify streaming status#66
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR improves TUI streaming-status clarity by replacing the vague default “Thinking” status with a more actionable “Waiting on network”, and by surfacing stalled streams with an explicit message (not just a spinner color change).
Changes:
- Introduces shared stall detection (
stream_is_stalled) and uses it for both spinner coloring and status text. - Updates streaming fallback label to “Waiting on network” and adds an explicit stalled-stream label.
- Adjusts status-row rendering logic so the status row is rendered during active streaming, and updates/extends tests accordingly.
Comments suppressed due to low confidence (1)
src-rust/crates/tui/src/render.rs:2217
should_render_status_rownow always returns true forapp.is_streaming, which makesinteresting_stream_statusand its placeholder-filtering redundant (the variable no longer affects the outcome). Simplifying avoids unnecessary per-frame work and keeps the intent clear.
fn should_render_status_row(app: &App) -> bool {
let interesting_stream_status = app
.status_message
.as_deref()
.map(|status| {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2163
to
2167
| /// Precedence: | ||
| /// 1. Adapter-set `status_message` (when it's not the generic | ||
| /// "thinking" placeholder) | ||
| /// 2. Running tool call — "Running <tool>" | ||
| /// 3. Active streaming text — "Generating" |
| @@ -3557,7 +3570,9 @@ | |||
| #[test] | |||
| fn streaming_status_label_falls_back_through_text_then_thinking() { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Waiting on networkStalled — check connection, Ctrl+C to interruptinstead of only recoloring the spinnerVerification
Fixes #57