fix(tui): surface hidden keybindings#65
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR improves keybinding discoverability in the TUI by surfacing previously “hidden” shortcuts (F2, Alt+H, Ctrl+B, and Tab mode cycling) across the footer, help UI, and onboarding page 2, and adds regression tests to ensure these hints remain visible.
Changes:
- Add footer hints for F2 / Alt+H / Ctrl+B / Tab when the prompt is idle.
- Extend both the full help overlay and the legacy/simple help overlay with the same shortcuts.
- Extend onboarding keybindings page (page 2) with familiar/help/branch shortcuts and add rendering assertions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src-rust/crates/tui/src/render.rs |
Adds footer hint text, expands legacy help key list, and adds a footer regression test. |
src-rust/crates/tui/src/overlays.rs |
Adds the hidden shortcuts to the full help overlay and adds a regression test. |
src-rust/crates/tui/src/onboarding_dialog.rs |
Adds new keybinding rows to onboarding page 2 and extends the render test assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if app.prompt_input.text.is_empty() && !app.is_streaming { | ||
| spans.push(Span::styled( | ||
| "F2 familiar Alt+H help Ctrl+B branch Tab mode", |
Comment on lines
2967
to
+2971
| kb_line("F1 / ?", "Toggle this help"), | ||
| kb_line("Alt+H", "Toggle this help"), | ||
| kb_line("F2", "Switch familiar"), | ||
| kb_line("Ctrl+B", "Create / switch branch"), | ||
| kb_line("Tab", "Cycle mode (build/plan/explore)"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: cargo fmt --all --check is blocked by unrelated formatting drift in current main under crates/cli and crates/core.
Fixes #56