fix(tui): improve contrast and spinner cadence#64
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Improves TUI accessibility and visual comfort by increasing muted/disabled text contrast and reducing the effective flash rate of the streaming status spinner.
Changes:
- Raised muted/disabled color values across themes to meet WCAG AA contrast targets on their intended backgrounds.
- Routed dim status/composer text through the shared
COVEN_CODE_MUTEDconstant for consistent styling. - Slowed the status spinner animation to advance every two render ticks and added a regression test for cadence.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src-rust/crates/tui/src/theme_colors.rs |
Updates per-theme disabled colors and adds a contrast-ratio test to enforce WCAG AA for muted/disabled text on representative theme backgrounds. |
src-rust/crates/tui/src/render.rs |
Imports COVEN_CODE_MUTED, uses it for dim status/composer text, slows spinner frame advancement, and adds a test ensuring the new cadence. |
src-rust/crates/tui/src/overlays.rs |
Updates the shared muted color constant used across overlay rendering to the higher-contrast value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes #55