fix(tui): complete Rune mascot rebrand#63
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR completes the TUI “Rustle” → “Rune” rebrand by renaming the mascot module/types/call-sites, updating docs and public assets, and adding a small Node smoke test to prevent legacy identifiers and filenames from reappearing.
Changes:
- Rename the TUI mascot module/API from
rustle/RustlePose/rustle_lines_fortomascot/CompanionPose/mascot_lines_for, updating render + app tick plumbing. - Update docs and CSS class naming from
tui-rustle→tui-mascot, plus README/COVEN/attribution references. - Add a
scripts/mascot-rebrand.test.mjssmoke test and rename mascot image assets toRune.png/Pirate-Rune.png.
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src-rust/crates/tui/src/render.rs | Switch welcome rendering to CompanionPose and new app field. |
| src-rust/crates/tui/src/mascot.rs | Rename pose type + slug helper, update glyph builders and tests. |
| src-rust/crates/tui/src/lib.rs | Export mascot module and remove rustle export. |
| src-rust/crates/tui/src/familiar_theme.rs | Update module references in docs to crate::mascot. |
| src-rust/crates/tui/src/familiar_card.rs | Update imports and pose handling to CompanionPose. |
| src-rust/crates/tui/src/app.rs | Rename pose field + tick/look-down APIs to companion terminology. |
| src-rust/crates/cli/src/main.rs | Call tick_companion_pose() in the interactive loop. |
| scripts/mascot-rebrand.test.mjs | Add smoke test guarding against legacy Rustle identifiers/assets. |
| README.md | Update mascot module path reference to mascot.rs. |
| public/Rune.png | Add renamed Rune mascot asset. |
| docs/src/style.css | Rename docs CSS class .tui-rustle → .tui-mascot. |
| docs/src/content/welcome-screen.js | Update markup to use the new .tui-mascot class. |
| COVEN.md | Update rebrand checklist section to match the new naming. |
| ATTRIBUTION.md | Update attribution note to reflect completed internal rename. |
Comments suppressed due to low confidence (2)
src-rust/crates/tui/src/mascot.rs:18
- The module docs say
mascot_lines_foris a “legacy entry point” that “routes through the theme/card path”, but the function currently just resolves a theme and callsarchetype_lines(no card rendering). This comment is misleading and should be updated to match the actual behavior.
src-rust/crates/tui/src/mascot.rs:496 - This test’s name/comment say it verifies palette differences while keeping glyph shape the same, but it currently compares two different archetypes (
kittyvsnova) and only checks that the text differs. That doesn’t validate palette handling and can confuse future refactors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustletomascotRustlePose/rustle_lines_forcall-sites to companion/mascot terminologyRune.pngandPirate-Rune.pngVerification
node scripts/mascot-rebrand.test.mjscargo fmt -p claurst-tui --checkcargo test -p claurst-tui mascotcargo check -p claurstgit diff --checkFixes #54