Skip to content

ci: fix macOS prepare_environment on stock GitHub runners #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
May 27, 2026
Merged

ci: fix macOS prepare_environment on stock GitHub runners #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/actions/prepare_environment/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,14 @@ runs:
# Try to install warp-channel-config but don't complain if it cannot
# be installed.
./script/install_channel_config || true
if ${{ inputs.install_release_deps == 'true' }}; then
if ${{ inputs.install_test_deps == 'true' }}; then
# Test deps include cargo-nextest (the test harness CI uses).
# The linux branch below already handles this; macOS used
# to fall through to install_cargo_build_deps, which doesn't
# install nextest -- so `cargo nextest run` blew up later
# with "no such command: nextest".
./script/install_cargo_test_deps
Comment on lines +101 to +105
elif ${{ inputs.install_release_deps == 'true' }}; then
./script/install_cargo_release_deps
else
./script/install_cargo_build_deps
Expand Down
18 changes: 17 additions & 1 deletion script/macos/install_build_deps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,20 @@
#
# Installs macOS-specific build dependencies required to build Warp.

xcodebuild -downloadComponent MetalToolchain
# `xcodebuild -downloadComponent` was added in Xcode 15.3. On stock
# GitHub `macos-latest` runners, this script executes *before*
# `prepare_environment` runs `setup-xcode` to select Xcode 26, so the
# active Xcode is still whatever ships with the runner image, which
# may not support the option. CI's `prepare_environment` action has a
# dedicated `Install selected Xcode Metal toolchain` step that retries
# this exact command after `setup-xcode`, so silently skipping here is
# safe for stock CI. Self-hosted runners hit this script with their
# own Xcode pre-selected and the call should succeed there.
if out=$(xcodebuild -downloadComponent MetalToolchain 2>&1); then
printf '%s\n' "$out"
elif printf '%s' "$out" | grep -q "invalid option '-downloadComponent'"; then
echo "xcodebuild -downloadComponent unsupported by current Xcode; skipping (CI retries after setup-xcode)."
Comment on lines +12 to +17
else
printf '%s\n' "$out" >&2
exit 1
fi
Loading