style: apply cargo fmt to browser + theme-import files by BunsDev · Pull Request #157 · OpenCoven/cast-codes

BunsDev · 2026-05-27T04:16:42Z

Summary

Apply cargo fmt to three files cargo flagged on main: browser_view.rs, browser_pane.rs (Layer A + B), and import_theme_modal.rs (theme import)
Unblocks the Formatting + Clippy jobs that started actually executing once ci: use stock github-hosted runners instead of warpdotdev SKUs #155 switched to stock GitHub runners
No behavioral changes

Why now

The unformatted code has been on main for several commits, but the Formatting + Clippy jobs never caught it because they were stuck queued indefinitely on the unprovisioned ubuntu-latest-large / windows-latest-large / namespace-profile-mac-ci runner labels. PR #155 fixes the runner labels; this PR fixes the fmt fallout so the jobs go green.

Test plan

CI Formatting + Clippy (Linux/Windows/wasm) jobs pass
cargo fmt --check runs clean on the merged result
No diff outside the three flagged files

🤖 Generated with Claude Code

Copilot

Pull request overview

This PR aims to apply cargo fmt to a small set of Rust UI/browser files that were previously unformatted on main, unblocking the Formatting + Clippy CI jobs after the runner-label fix in #155.

Changes:

Reflowed match arms and closures in BrowserView (find overlay handlers, zoom-step access).
Reformatted constructor/signature layout in BrowserPane.
Minor formatting normalization in the theme import modal status/save paths.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
app/src/settings_view/import_theme_modal.rs	Small formatting-only changes to error assignment and idle-state tuple formatting.
app/src/pane_group/pane/browser_pane.rs	Reformatting of function signatures and a view-construction statement.
app/src/browser/browser_view.rs	Reformatting around editor subscriptions, zoom-step retrieval, and action match arms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

-        session_id: String,
-        ctx: &mut ViewContext<V>,
-    ) -> Self {
+    pub fn new<V: View>(url: Option<String>, session_id: String, ctx: &mut ViewContext<V>) -> Self {


-        visible: bool,
-        ctx: &mut ViewContext<PaneGroup>,
-    ) {
+    fn on_workspace_tab_visibility_changed(&self, visible: bool, ctx: &mut ViewContext<PaneGroup>) {


            BrowserViewAction::ToggleFind => self.toggle_find(ctx),
            BrowserViewAction::CloseFind => self.close_find(ctx),
-            BrowserViewAction::FindNext => {
+            BrowserViewAction::FindNext =>
+            {
                #[cfg(not(target_family = "wasm"))]


                }
            }
-            BrowserViewAction::FindPrev => {
+            BrowserViewAction::FindPrev =>
+            {
                #[cfg(not(target_family = "wasm"))]


main carries three unformatted files inherited from feature commits that landed while heavy CI jobs (Formatting + Clippy) were stuck queueing on unprovisioned warpdotdev runner labels. Now that PR #155 switches to stock GitHub runners, those jobs actually execute and fail the fmt check, blocking every PR. Apply `cargo fmt` to the three files cargo flagged: - app/src/browser/browser_view.rs (Layer A + B) - app/src/pane_group/pane/browser_pane.rs (Layer A + B) - app/src/settings_view/import_theme_modal.rs (theme import) No behavioral changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Now that PR #155 made the heavy CI jobs actually execute (stock GitHub runners instead of unprovisioned warpdotdev SKUs), the clippy half of the Formatting + Clippy job surfaces 40+ preexisting `-D warnings` violations on main. This commit lands the mechanical / cheap ones: - `items_after_test_module`: move test mod to end of file in workspace/view.rs and settings_view/main_page.rs. - `disallowed_types`: swap `std::process::Command` for the Windows-friendly `command::blocking::Command` wrapper inside util/git_tests.rs (1) and util/worktree_tests.rs (5). - `dead_code` in scaffolding-only browser modules (downloads.rs, popup_policy.rs): allow at module level. Both modules are consumed only by browser/webview_host.rs's in-progress popup + download wiring; deleting them would tear out the follow-up work. Module-level allow keeps the call graph intact until the wry handlers land. No behavioral changes. Remaining clippy fallout (mostly more dead_code in browser + cli_chat scaffolding plus a handful of one-off lints) tracked in follow-up commits. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Round 2 of the heavy-CI fallout. With #155 making jobs actually run, clippy on Linux flagged 30+ more violations. Split between dead_code allows on in-progress scaffolding and one-off lint fixes: Browser pane (in-progress wry wiring, currently macOS-only): - webview_host.rs: gate `FindResultsMessage` and `popup_policy::*` imports to target_os = "macos" so non-macOS builds don't pull them in just to fail dead_code; add struct-level + enum-level `#[allow(dead_code)]` to `NativeBrowserWebView` and `NativeWebViewEvent` since their fields/variants are constructed only by macOS handlers. - browser_model.rs: allow pinned/favicon accessors + mutators (tab strip UI scaffolding). - find.rs: allow `FindResultsMessage` (deserialized only inside the macOS-gated IPC handler). - browser_view.rs: allow `too_many_arguments` on the two render helpers; drop a useless `.into()` on `chip_text_color`. CLI chat (Phase 5/6 scaffolding): - cli_chat/mod.rs: tag each `pub mod` declaration with `#[allow(dead_code)]` since the layers compile but no caller binds them yet. - empty_state.rs: allow `enum_variant_names` (all "No…" prefixes are intentional UX strings, not naming churn). - model_picker.rs: drop `&` on a `&&ChatModel` arg. - store.rs: replace `|row| row_to_conversation(row)` closure with the function pointer (`redundant_closure`). - store_schema.rs: rewrite the migrations loop to use `iter().enumerate().skip(...)` instead of indexing (`needless_range_loop`). Cross-cutting one-offs: - claude_transcript.rs: drop a stray blank line between the doc and `validated_stem`. - coven_brand.rs: allow `OPENCOVEN_MUTED` (kept for follow-up UI use). - server_api.rs: allow `AccessTokenRefreshed::token` field on all platforms (was already wasm-only). - settings/import/config.rs: allow `large_enum_variant` on `ThemeType` (cold path, one allocation per import). - terminal/view/pane_impl.rs: collapse identical `if/else` returning the same string; rename the parameter to `_` and document the follow-up that distinguishes ambient vs regular labels. - themes/tweakcn_import.rs: drop a `format!("{}", selector)` that's literally the identity, and factor the heavy fn-pointer type into a `UiTokenSetter` alias to satisfy `type_complexity`. No behavioural changes. Remaining: the `disallowed_type std::process::Command` errors landed in commit 3315e06; this commit covers the lib lints. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

PR #157's first heavy CI run validated the Linux clippy fix (passes green) but surfaced two additional platform-specific lints that Linux didn't trigger: - cast_agent/src/comux.rs: gate `ListPanesRequest` and `ListPanesResponse` to `#[cfg(unix)]` to match the only call site (the unix-only block at line 96). On Windows the structs compiled but no constructor existed, so dead_code fired. - warp_cli/src/lib.rs: split the `std::ffi::OsString` import out of the unconditional `use std::{env, ffi::OsString, ...}` line and gate it to `#[cfg(not(target_family = "wasm"))]`, matching the three OsString-using helpers that are already wasm-gated. No behavioural changes; just import + cfg housekeeping. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

BunsDev · 2026-05-27T06:34:32Z

Pushed b8345389 to address Windows + wasm clippy failures. CI didn't auto-trigger on the new commit; nudging with this comment.

Two more wasm-only clippy errors surfaced once #157's main-side fmt fixes shipped: - crates/lsp/src/model.rs: split `LspStartupError` out of the unconditional `use ... supported_servers::{...}` group. The only usage (the downcast inside `LspServerModel::start`) is already `#[cfg(not(target_arch = "wasm32"))]`; the import is now too. - crates/lsp/src/supported_servers.rs: gate `LspStartupError::missing_binary` to non-wasm too. It's the only constructor of `LspStartupError`, and only `start` calls it, so on wasm the function was unused. No behavioural changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

PR #157's first heavy CI run validated the Linux clippy fix (passes green) but surfaced two additional platform-specific lints that Linux didn't trigger: - cast_agent/src/comux.rs: gate `ListPanesRequest` and `ListPanesResponse` to `#[cfg(unix)]` to match the only call site (the unix-only block at line 96). On Windows the structs compiled but no constructor existed, so dead_code fired. - warp_cli/src/lib.rs: split the `std::ffi::OsString` import out of the unconditional `use std::{env, ffi::OsString, ...}` line and gate it to `#[cfg(not(target_family = "wasm"))]`, matching the three OsString-using helpers that are already wasm-gated. No behavioural changes; just import + cfg housekeeping. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Two more wasm-only clippy errors surfaced once #157's main-side fmt fixes shipped: - crates/lsp/src/model.rs: split `LspStartupError` out of the unconditional `use ... supported_servers::{...}` group. The only usage (the downcast inside `LspServerModel::start`) is already `#[cfg(not(target_arch = "wasm32"))]`; the import is now too. - crates/lsp/src/supported_servers.rs: gate `LspStartupError::missing_binary` to non-wasm too. It's the only constructor of `LspStartupError`, and only `start` calls it, so on wasm the function was unused. No behavioural changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings May 27, 2026 04:16

Copilot started reviewing on behalf of BunsDev May 27, 2026 04:16 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

BunsDev force-pushed the fix/cargo-fmt-on-main branch from f308922 to 02dc226 Compare May 27, 2026 05:28

BunsDev and others added 2 commits May 27, 2026 00:51

BunsDev merged commit 3f847ec into main May 27, 2026
16 of 23 checks passed

BunsDev mentioned this pull request May 27, 2026

fix(clippy): platform-specific dead_code on Windows + wasm #159

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

style: apply cargo fmt to browser + theme-import files#157

style: apply cargo fmt to browser + theme-import files#157
BunsDev merged 3 commits into
mainfrom
fix/cargo-fmt-on-main

BunsDev commented May 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

BunsDev commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

BunsDev commented May 27, 2026

Summary

Why now

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

BunsDev commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants