Skip to content

[WIP] Fix grammatical error and remove deprecated GitHub Actions commands#12

Closed
BunsDev with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-grammatical-error-and-remove-deprecated-comman
Closed

[WIP] Fix grammatical error and remove deprecated GitHub Actions commands#12
BunsDev with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-grammatical-error-and-remove-deprecated-comman

Conversation

Copilot AI commented May 14, 2026

Copy link
Copy Markdown

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt
Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"Corrected grammatical error: 'and before enabling' should be 'before enabling'.","fixFiles":[{"filePath":"script/wasm/bundle","diff":"diff --git a/script/wasm/bundle b/script/wasm/bundle\n--- a/script/wasm/bundle\n+++ b/script/wasm/bundle\n@@ -20,7 +20,7 @@\n \n # By default we build dev bundles.\n RELEASE_CHANNEL=\"dev\"\n-# TODO: We should enable crash_reporting and before enabling for trusted testers.\n+# TODO: We should enable crash_reporting before enabling for trusted testers.\n # https://linear.app/warpdotdev/issue/PLAT-428/crash-reporting-on-web\n FEATURES=\"release_bundle,gui\"\n DEBUG=false\n"}]},{"message":"The `::echo::on` and `::echo::off` commands are deprecated in GitHub Actions. These commands were used to control command echoing but are no longer necessary or supported. Remove these lines as they have no effect.","fixFiles":[{"filePath":"script/wasm/bundle","diff":"diff --git a/script/wasm/bundle b/script/wasm/bundle\n--- a/script/wasm/bundle\n+++ b/script/wasm/bundle\n@@ -165,9 +165,7 @@\n # If this is being run within a GitHub action, set an output variable with the\n # directory containing all built packages.\n if [ \"${GITHUB_ACTIONS}\" == \"true\" ]; then\n-  echo \"::echo::on\"\n   echo \"packages_dir=$OUT_DIR\" >> \"$GITHUB_OUTPUT\"\n   echo \"assets_dir=$ASSET_TARGET_DIR\" >> \"$GITHUB_OUTPUT\"\n   echo \"debug_executable_path=$WASM_BINARY_DEBUG\" >> \"$GITHUB_OUTPUT\"\n-  echo \"::echo::off\"\n fi\n"}]}]

@BunsDev

BunsDev commented May 15, 2026

Copy link
Copy Markdown
Member

Superseded by #15 which implements all four fixes.

@BunsDev BunsDev closed this May 15, 2026
BunsDev added a commit that referenced this pull request May 15, 2026
…et -e, remove deprecated ::echo:: commands (#15)

- bundle.ps1: remove premature $BUNDLE_ID assignment using undefined $app_name (fixes #11)
- install_build_deps: guard /etc/os-release source with file existence check (fixes #13)
- install_cargo_bundle: move set -e to top of script so all failures are caught (fixes #14)
- Grammatical fix in wasm/bundle comment (fixes #12)
- Remove deprecated ::echo::on/off GitHub Actions commands from all bundle scripts and workflows (fixes #12)
@BunsDev
BunsDev deleted the copilot/fix-grammatical-error-and-remove-deprecated-comman branch June 15, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants