Skip to content

[php-nextgen] Test with phpstan #24146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 3 commits into from
Jun 28, 2026
+37 −0
Merged

[php-nextgen] Test with phpstan #24146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98ac517
test with phpstan
wing328 Jun 28, 2026
f5aa3f2
update
wing328 Jun 28, 2026
096bdf9
Merge remote-tracking branch 'origin/master' into php-nextgen-query-test
wing328 Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/samples-php-nextgen-phpstan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Samples php-nextgen (phpstan)

on:
push:
paths:
- samples/client/petstore/php-nextgen/OpenAPIClient-php/**
pull_request:
paths:
- samples/client/petstore/php-nextgen/OpenAPIClient-php/**
jobs:
build:
name: Build
runs-on: ubuntu-latest
strategy:
fail-fast: true

@cubic-dev-ai cubic-dev-ai Bot Jun 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: fail-fast: true cancels the remaining PHP-version matrix jobs on the first failure, losing visibility into whether other versions pass. All other PHP workflows in this repo use fail-fast: false to collect results across all PHP versions.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/samples-php-nextgen-phpstan.yaml, line 15:

<comment>`fail-fast: true` cancels the remaining PHP-version matrix jobs on the first failure, losing visibility into whether other versions pass. All other PHP workflows in this repo use `fail-fast: false` to collect results across all PHP versions.</comment>

<file context>
@@ -0,0 +1,35 @@
+    name: Build 
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        php:
</file context>
Suggested change
fail-fast: true
fail-fast: false

matrix:
php:
- "8.1"
- "8.2"
- "8.3"
- "8.4"
sample:
# clients
- samples/client/petstore/php-nextgen/OpenAPIClient-php/
steps:
- uses: actions/checkout@v7
- name: Setup PHP with tools
uses: shivammathur/setup-php@v2
with:
php-version: "${{ matrix.php }}"
- name: phpstan
working-directory: ${{ matrix.sample }}
run: |
composer require --dev phpstan/phpstan
vendor/bin/phpstan analyse src
2 changes: 2 additions & 0 deletions samples/client/petstore/php-nextgen/OpenAPIClient-php/.openapi-generator-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@
#!docs/README.md
#
#
#
#
Loading