Skip to content

[php-nextgen] Test with phpstan#24146

Merged
wing328 merged 3 commits into
masterfrom
php-nextgen-query-test
Jun 28, 2026
Merged

[php-nextgen] Test with phpstan#24146
wing328 merged 3 commits into
masterfrom
php-nextgen-query-test

Conversation

@wing328

@wing328 wing328 commented Jun 28, 2026

Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add phpstan/phpstan static analysis to CI for the php-nextgen PHP sample to catch type issues early. Also tidy .openapi-generator-ignore comments.

  • Dependencies
    • Adds a GitHub Actions workflow scoped to samples/client/petstore/php-nextgen/OpenAPIClient-php, runs on PHP 8.1–8.4, installs phpstan/phpstan via Composer, and runs vendor/bin/phpstan analyse src.

Written for commit 096bdf9. Summary will update on new commits.

Review in cubic

@wing328 wing328 changed the title test with phpstan [php-nextgen] Test with phpstan Jun 28, 2026
@wing328 wing328 added this to the 7.24.0 milestone Jun 28, 2026
@wing328 wing328 marked this pull request as ready for review June 28, 2026 14:42

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/samples-php-nextgen-phpstan.yaml">

<violation number="1" location=".github/workflows/samples-php-nextgen-phpstan.yaml:15">
P2: `fail-fast: true` cancels the remaining PHP-version matrix jobs on the first failure, losing visibility into whether other versions pass. All other PHP workflows in this repo use `fail-fast: false` to collect results across all PHP versions.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

name: Build
runs-on: ubuntu-latest
strategy:
fail-fast: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: fail-fast: true cancels the remaining PHP-version matrix jobs on the first failure, losing visibility into whether other versions pass. All other PHP workflows in this repo use fail-fast: false to collect results across all PHP versions.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/samples-php-nextgen-phpstan.yaml, line 15:

<comment>`fail-fast: true` cancels the remaining PHP-version matrix jobs on the first failure, losing visibility into whether other versions pass. All other PHP workflows in this repo use `fail-fast: false` to collect results across all PHP versions.</comment>

<file context>
@@ -0,0 +1,35 @@
+    name: Build 
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        php:
</file context>
Suggested change
fail-fast: true
fail-fast: false

@wing328 wing328 merged commit 45b2af4 into master Jun 28, 2026
40 checks passed
@wing328 wing328 deleted the php-nextgen-query-test branch June 28, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant