[php-nextgen] Test with phpstan#24146
Merged
Merged
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/samples-php-nextgen-phpstan.yaml">
<violation number="1" location=".github/workflows/samples-php-nextgen-phpstan.yaml:15">
P2: `fail-fast: true` cancels the remaining PHP-version matrix jobs on the first failure, losing visibility into whether other versions pass. All other PHP workflows in this repo use `fail-fast: false` to collect results across all PHP versions.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| name: Build | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: true |
Contributor
There was a problem hiding this comment.
P2: fail-fast: true cancels the remaining PHP-version matrix jobs on the first failure, losing visibility into whether other versions pass. All other PHP workflows in this repo use fail-fast: false to collect results across all PHP versions.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/samples-php-nextgen-phpstan.yaml, line 15:
<comment>`fail-fast: true` cancels the remaining PHP-version matrix jobs on the first failure, losing visibility into whether other versions pass. All other PHP workflows in this repo use `fail-fast: false` to collect results across all PHP versions.</comment>
<file context>
@@ -0,0 +1,35 @@
+ name: Build
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: true
+ matrix:
+ php:
</file context>
Suggested change
| fail-fast: true | |
| fail-fast: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Add
phpstan/phpstanstatic analysis to CI for thephp-nextgenPHP sample to catch type issues early. Also tidy.openapi-generator-ignorecomments.samples/client/petstore/php-nextgen/OpenAPIClient-php, runs on PHP 8.1–8.4, installsphpstan/phpstanvia Composer, and runsvendor/bin/phpstan analyse src.Written for commit 096bdf9. Summary will update on new commits.