CI: add nightly Android Lint job#1914
Merged
Merged
Conversation
Every PR/push and nightly Gradle invocation passes -x lint, so the lint-clean, baseline-free state from the earlier lint campaign has had nothing enforcing it since lint was pulled off the PR path. Add a lint job to android-nightly.yml running lintObaGoogleDebug with -PwarningsAsErrors=true (no emulator needed) and upload the HTML report as an artifact. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
bmander
added a commit
that referenced
this pull request
Jul 17, 2026
The lint job added in #1914 is the first run of lintObaGoogleDebug since lint was pulled off PR/push CI in #1843, so two unrelated regressions from that gap surfaced together: - AdjacencyRouteColors.kt's @SuppressLint("RestrictedApi") covers adjacencyRouteColors() but not the private routeColor() it calls, where the actual restricted Hct.from(...).toInt() calls live. - #1865 added new optional parameters ahead of the existing `modifier` parameter in RouteArrivalRow and ArrivalsList, breaking the Compose convention that modifier be the first optional parameter. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lintjob toandroid-nightly.ymlthat runs./gradlew :onebusaway-android:lintObaGoogleDebug -PwarningsAsErrors=trueand uploads the HTML report as an artifact. No emulator needed, so it's cheap to run nightly.android.ymlandandroid-nightly.ymlthat described the nightly lint job as "slated"/"never landed" to point at the new job.Fixes #1901. Every PR/push and nightly Gradle invocation passes
-x lint, so the lint-clean, baseline-free state won by the earlier lint campaign (#1875) has had nothing enforcing it since lint was pulled off the PR path — this closes that gap without slowing down the PR critical path.Test plan
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/android-nightly.yml'))"— YAML parsespython3 -c "import yaml; yaml.safe_load(open('.github/workflows/android.yml'))"— YAML parses./gradlew :onebusaway-android:tasks --allconfirmslintObaGoogleDebugexists as a tasklintjob runs green on the next scheduled nightly (or via manualworkflow_dispatch)🤖 Generated with Claude Code