Fix lint errors surfaced by the new nightly lint job (#1937)

The lint job added in #1914 is the first run of lintObaGoogleDebug since
lint was pulled off PR/push CI in #1843, so two unrelated regressions from
that gap surfaced together:

- AdjacencyRouteColors.kt's @SuppressLint("RestrictedApi") covers
  adjacencyRouteColors() but not the private routeColor() it calls, where
  the actual restricted Hct.from(...).toInt() calls live.
- #1865 added new optional parameters ahead of the existing `modifier`
  parameter in RouteArrivalRow and ArrivalsList, breaking the Compose
  convention that modifier be the first optional parameter.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Author: bmander

onebusaway-android/src/main/java/org/onebusaway/android/map/AdjacencyRouteColors.kt

@@ -52,6 +52,9 @@ internal fun <K : Any> adjacencyRouteColors(
     return keys.associateWith(assigned::getValue)
 }
 
+// Hct is Material Components' vendored color-science util (LIBRARY_GROUP); no public equivalent
+// exists, so this is deliberate long-term use, not a migration to track (same as LineBadge).
+@SuppressLint("RestrictedApi")
 private fun routeColor(hue: Double): Int =
     Hct.from(hue, ADJACENCY_ROUTE_CHROMA, ADJACENCY_ROUTE_TONE).toInt()
 

onebusaway-android/src/main/java/org/onebusaway/android/ui/arrivals/ArrivalsScreen.kt

@@ -340,6 +340,7 @@ internal fun ArrivalsList(
     /** Whether a load-more request is in flight, for the footer button's spinner. Collected only by
      *  the footer item below, so a toggle recomposes just that item, not the whole list. */
     loadingMore: StateFlow<Boolean>,
+    modifier: Modifier = Modifier,
     /** Stop-focus map colors keyed by route-direction. Empty outside the home drawer. */
     mapRouteColors: Map<RouteDirectionKey, Int> = emptyMap(),
     /** Exact route-direction row selected over the home map's stop focus; null outside that state. */
@@ -348,7 +349,6 @@ internal fun ArrivalsList(
     selectedRouteId: String? = null,
     /** Route names in the selected vehicle block, beginning with the route on this row. */
     selectedRouteNames: List<String> = emptyList(),
-    modifier: Modifier = Modifier,
     listState: LazyListState = rememberLazyListState(),
     /** Hosts that show the stop's direction elsewhere (e.g. in their own header) set this false to
      *  avoid duplicating it as a list item. */

onebusaway-android/src/main/java/org/onebusaway/android/ui/arrivals/components/ArrivalRows.kt

@@ -260,10 +260,10 @@ fun RouteArrivalRow(
     actionsFor: (ArrivalInfo) -> ArrivalActions?,
     isFavorite: Boolean,
     callbacks: ArrivalRowCallbacks,
+    modifier: Modifier = Modifier,
     mapRouteColor: Int? = null,
     selected: Boolean = false,
     selectedRouteNames: List<String> = emptyList(),
-    modifier: Modifier = Modifier,
     etaAnchor: Modifier = Modifier,
 ) {
     val representative = group.representative