[16.0] [FIX] stock_picking_report_valued_sale_mrp: fix components per kit computation when redelivering#454
Conversation
|
Hi @chienandalu, |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
|
This PR has the |
|
@rousseldenis could you merge this one? |
github-actions
Bot
removed
the
stale
|
@pedrobaeza could U merge this one? |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Don't introduce extra empty lines inside methods, and please reduce AI usage to the minimum, as the code is bloated due to it.
…omponents by kit when delivery-return-redelivery
…alculation to exclude returned moves
rrebollo
force-pushed
the
16.0-stock_picking_report_valued_sale_mrp-fix-components-per-kit-when-redelivering
branch
from
8610353 to
0eb42b7
Compare
OCA-git-bot
added
mod:stock_picking_report_valued_sale_mrp
|
@pedrobaeza what do U think? can we merge it now? |
| line.quantity_done = line.product_uom_qty | ||
| return_picking.button_validate() | ||
| # Redelivery | ||
| sale._action_cancel() |
There was a problem hiding this comment.
This is not the usual flow, but to return the return, so I'm not doubting your code serves for this purpose.
There was a problem hiding this comment.
Do you mean "now doubting"? The first one to question my code was me:
🛠️ Proposed Fix
This PR provides an initial attempt to resolve the incorrect quantity computation. Additional details and discussion can be found in the linked issue.
The issue is documented in #451. Please take some time to suggest a better approach if you have one.
There was a problem hiding this comment.
@pedrobaeza, now I understand your point. The usual flow is to return the return not to cancel the return. I need to dig deeper into those scenarios. Thank you.
6 participants
Fixes #451
This PR contains two commits:
🧩 Context
The problem occurs in the following workflow:
At this point, the system generate another picking and you validate this too, and we noticed that the kit component quantities shown on the delivery slip report were incorrect.
🔍 Root Cause
The issue appears to stem from the calculation of the component quantities per kit during this sequence of operations.
🛠️ Proposed Fix
This PR provides an initial attempt to resolve the incorrect quantity computation. Additional details and discussion can be found in the linked issue.
HT14789
@BinhexTeam