[18.0][MIG] stock_average_daily_sale by rousseldenis · Pull Request #481 · OCA/stock-logistics-reporting

rousseldenis · 2026-03-12T14:48:30Z

No description provided.

rousseldenis · 2026-03-12T14:48:39Z

jbaudoux

can you drop the migrations folder?

…evel + add demo The configurations are now stored on abc profiles. Some demo data are loaded in order to show this module features more easily.

…ame to recommended_qty

By default the priority in odoo is set to '0'. Before this change the daily sale was never computed for moves done in a normal process. There is no need to filter out moves based on the priority from the computation.

Co-authored-by: Jacques-Etienne Baudoux <je@bcim.be>

…rn browse record

…ized view

As tests create a Savepoint, there is a concurrent query when checking the view existence.

As for x reason, some products appear more than one time in the report, id generated by the concatenation of product_id and warehouse_id is irrelevant (as duplicate values possible). Use row_number() instead

Currently translated at 100.0% (58 of 58 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_average_daily_sale Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_average_daily_sale/it/

Remove product_abc_classification dependency. This module is not essential for the current module to function properly.

Only stock_user can see config and report; stock_manager can create and delete config entries

Set default average_daily_sale_root_location on WH create. Default stock location of the new WH is used for this purpose

Allow to decide if weekends should be included or excluded in average daily sale calculation.

Take also production location as dest location for daily usage calculation

…ny_id stock_average_daily_sale: - add form view for config - add company_id to config - allow editing ABC classification level and make sure the level is unique per warehouse

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_average_daily_sale Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_average_daily_sale/

Currently translated at 100.0% (59 of 59 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_average_daily_sale Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_average_daily_sale/it/

- Allow to set a location from which consumption are computed - Properly compute the average daily quantity - Add max daily consumption metric - Remove stock level, this is not relevant for this report - Drop spike exclusion as it was counter-productive the way it was used - Moved safety and recommended quantity as computed field so that it can be extended - Added multi-company rules

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_average_daily_sale Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_average_daily_sale/

Currently translated at 100.0% (57 of 57 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_average_daily_sale Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_average_daily_sale/it/

rousseldenis · 2026-03-13T06:53:49Z

@jbaudoux ready

rrebollo

I believe most of the findings are optional, but a few need to be addressed at this point. For all those cases, I've provided a suggestion that should make the change straightforward.

rrebollo · 2026-03-23T20:28:58Z

+from psycopg2.errors import ObjectNotInPrerequisiteState
+from psycopg2.extensions import AsIs
+
+from odoo import _, api, fields, models, registry


Suggested change

from odoo import _, api, fields, models, registry

from odoo import api, fields, models

from odoo.modules.registry import Registry

From OCA Migration Guidelines to v18:

Instead of doing from odoo import registry and then registry(db_name), now you have to do from odoo.modules.registry import Registry and Registry(db_name). More info at odoo/odoo#178784.

Also translations are environment related now.

rrebollo · 2026-03-23T20:29:50Z

+
+    @api.model
+    def _check_view(self):
+        cr = registry(self._cr.dbname).cursor()


Suggested change

cr = registry(self._cr.dbname).cursor()

cr = Registry(self._cr.dbname).cursor()

Idem

rrebollo · 2026-03-23T20:32:25Z

+    def search(self, domain, offset=0, limit=None, order=None):
+        if not config["test_enable"] and not self._check_view():
+            return self.browse()
+        return super().search(domain=domain, offset=offset, limit=limit, order=order)


Did you consider OCA Migration Guidelines? Given this model is really a materialized table I'm guessing this is not relevant. Am I wrong?

If overriding search method for modifying searches result, take into account that this method is not always called in this version. Override search_fetch instead.

rrebollo · 2026-03-23T20:36:55Z

+class StockAverageDailySaleConfig(models.Model):
+    _name = "stock.average.daily.sale.config"
+    _description = "Average daily sales computation parameters"
+    check_company_auto = True


Suggested change

check_company_auto = True

_check_company_auto = True

Looks like a typo. Anyway I think it's better to address this now.

rrebollo · 2026-03-23T20:47:09Z

Also @rousseldenis, would you be so kind to review my #479 in return?

rrebollo · 2026-03-23T21:04:43Z

+                return self._check_materialize_view_populated(cr)
+            except ObjectNotInPrerequisiteState:
+                _logger.warning(
+                    _("The materialized view has not been populated. Launch the cron.")


Suggested change

_("The materialized view has not been populated. Launch the cron.")

self.env._("The materialized view has not been populated. Launch the cron.")

jbaudoux

I'm planning to improve and refactor this module in v18.0.
I noted as comment what I intend to change

jbaudoux · 2026-04-14T08:16:42Z

+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+{
+    "name": "Stock Average Daily Sale",


Can we rename the module to

Suggested change

"name": "Stock Average Daily Sale",

"name": "Stock Average Daily Usage",

jbaudoux · 2026-04-14T08:17:20Z

+    "maintainers": ["jbaudoux"],
+    "website": "https://github.com/OCA/stock-logistics-reporting",
+    "depends": [
+        "sale",


It should only depend on stock

jbaudoux · 2026-04-14T08:18:26Z

+    "website": "https://github.com/OCA/stock-logistics-reporting",
+    "depends": [
+        "sale",
+        "stock_storage_type_putaway_abc",


I would like to drop this strong dependency and move it to a glue module. Or even better, replace it with a products applicability domain. At the end, it is the only thing that it is doing.

Also it would be better to use the abc product classification level that is at product.product level (abc_storage is only at product.template level) and that supports multi-warehouses through the abc profiles.

jbaudoux · 2026-04-14T08:19:27Z

+    "depends": [
+        "sale",
+        "stock_storage_type_putaway_abc",
+        "product_route_mto",


MTO should move to another glue module. It doesn't provide any value to this ADU computation.

New module: stock_average_daily_usage_mto

jbaudoux · 2026-04-14T08:37:32Z

+    nbr_sales = fields.Integer(
+        string="Number of Sales",


rename to reflect what it is

jbaudoux · 2026-04-14T09:18:08Z

+    abc_classification_level = fields.Selection(
+        selection=ABC_SELECTION, required=True, default="b"
+    )


move out of this module

jbaudoux · 2026-05-27T15:40:29Z

Fix PRs to include:

rousseldenis added needs review migration labels Mar 12, 2026

rousseldenis changed the title ~~18.0 mig stock average daily sale dro~~ [18.0][MIG] stock_average_daily_sale Mar 12, 2026

jbaudoux reviewed Mar 12, 2026

View reviewed changes

rousseldenis marked this pull request as draft March 12, 2026 14:52

rousseldenis force-pushed the 18.0-mig-stock_average_daily_sale-dro branch from c660290 to 4a7a4e6 Compare March 12, 2026 15:19

rousseldenis and others added 23 commits March 12, 2026 16:59

[16.0][ADD] stock_average_daily_sale

76927b6

[IMP] stock_average_daily_sale: Store the configurations on profile l…

6a08cb3

…evel + add demo The configurations are now stored on abc profiles. Some demo data are loaded in order to show this module features more easily.

[IMP] stock_average_daily_sale: Improve profile view

24da91d

[IMP] Remove zone location dependency, rely on warehouse only

b68b2ad

[IMP] stock_average_daily_sale: Improve tests

c84556e

[IMP] stock_average_daily_sale: Improve module helps / change field n…

0972a77

…ame to recommended_qty

[FIX] stock_average_daily_sale: Don't exclude moves on priority

3c1f2b4

By default the priority in odoo is set to '0'. Before this change the daily sale was never computed for moves done in a normal process. There is no need to filter out moves based on the priority from the computation.

[IMP] stock_average_daily_sale: Don't use Odoo demo data

720b1b8

[IMP] stock_average_daily_sale: add contributor

d0c4a12

Co-authored-by: Jacques-Etienne Baudoux <je@bcim.be>

[IMP] stock_average_daily_sale: Avoid errors in all searches and retu…

76949d3

…rn browse record

[FIX] stock_average_daily_sale: Use a new cursor to avoid closed one

418fae6

[FIX] stock_average_daily_sale: Don't test the not refreshed material…

d2f3ee6

…ized view

[FIX] stock_average_daily_sale: Don't check the view existence in tests

ef74524

As tests create a Savepoint, there is a concurrent query when checking the view existence.

[FIX] stock_average_daily_sale: Don't rely on tuples as id

a9762f3

As for x reason, some products appear more than one time in the report, id generated by the concatenation of product_id and warehouse_id is irrelevant (as duplicate values possible). Use row_number() instead

[IMP] stock_average_daily_sale: avoid concurrent update

2e883e9

[UPD] Update stock_average_daily_sale.pot

8e4ee93

[BOT] post-merge updates

dec61ff

Added translation using Weblate (Italian)

e32e610

stock_average_daily_sale: Remove product_abc_classification dependency

eb5e2ef

Remove product_abc_classification dependency. This module is not essential for the current module to function properly.

stock_average_daily_sale: Change default access rights

ea59984

Only stock_user can see config and report; stock_manager can create and delete config entries

stock_average_daily_sale: Set default root location on WH

2349d76

Set default average_daily_sale_root_location on WH create. Default stock location of the new WH is used for this purpose

stock_average_daily_sale: Allow to include/exclude weekends

033be95

Allow to decide if weekends should be included or excluded in average daily sale calculation.

twalter-c2c and others added 15 commits March 12, 2026 16:59

stock_average_daily_sale: Take production location into account

c9f83e5

Take also production location as dest location for daily usage calculation

stock_average_daily_sale: Config adjustment - add from view and compa…

b8a136a

…ny_id stock_average_daily_sale: - add form view for config - add company_id to config - allow editing ABC classification level and make sure the level is unique per warehouse

stock_average_daily_sale: Pre-migration script

deb1602

stock_average_daily_sale: Specify WH on demo stock moves

3760faf

[UPD] Update stock_average_daily_sale.pot

0b69fe6

[BOT] post-merge updates

905d470

stock_average_daily_sale: improve fields visibility

3a1cdf1

[UPD] Update stock_average_daily_sale.pot

bdbad17

[BOT] post-merge updates

87c0829

[IMP] stock_average_daily_sale: pre-commit autofixes

a57f5e0

rousseldenis force-pushed the 18.0-mig-stock_average_daily_sale-dro branch from 4a7a4e6 to 934b126 Compare March 12, 2026 15:59

rousseldenis added 2 commits March 13, 2026 07:44

[MIG] stock_average_daily_sale: Migration to 18.0

58cc98f

[FIX] stock_average_daily_sale: Don't translate sql constraint

27c782c

rousseldenis force-pushed the 18.0-mig-stock_average_daily_sale-dro branch from c9fc84f to 27c782c Compare March 13, 2026 06:44

rousseldenis marked this pull request as ready for review March 13, 2026 06:52

jbaudoux approved these changes Mar 13, 2026

View reviewed changes

rrebollo suggested changes Mar 23, 2026

View reviewed changes

rrebollo reviewed Mar 23, 2026

View reviewed changes

jbaudoux reviewed Apr 14, 2026

View reviewed changes

	from odoo import _, api, fields, models, registry
	from odoo import api, fields, models
	from odoo.modules.registry import Registry

	cr = registry(self._cr.dbname).cursor()
	cr = Registry(self._cr.dbname).cursor()

	_("The materialized view has not been populated. Launch the cron.")
	self.env._("The materialized view has not been populated. Launch the cron.")

	"name": "Stock Average Daily Sale",
	"name": "Stock Average Daily Usage",

Uh oh!

Conversation

rousseldenis commented Mar 12, 2026

Uh oh!

rousseldenis commented Mar 12, 2026

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Mar 13, 2026

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

rrebollo Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rrebollo commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbaudoux Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbaudoux commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rrebollo Mar 23, 2026 •

edited

Loading

rrebollo commented Mar 23, 2026 •

edited

Loading

jbaudoux Apr 14, 2026 •

edited

Loading