[19.0][FIX] test-requirements: use httpx2 for starlette TestClient#620
Merged
Merged
Conversation
Author
|
@glitchov could you please approve? This would unlock several migrations. Thanks! |
rvalyi
approved these changes
Jun 22, 2026
rvalyi
left a comment
Member
There was a problem hiding this comment.
indeed, already httpx2 in 18.0 but as the files is not part of any Odoo module it was not carried to the 19.0 branch https://github.com/OCA/rest-framework/blob/18.0/test-requirements.txt#L2
Member
|
trivial, fast tracking... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 19.0,
test-requirements.txtpinshttpx, but starlette'sTestClientin this stack importshttpx2(import httpx2 as httpx). Withouthttpx2installed, the TestClient falls back tohttpxand emits aStarletteDeprecationWarning, which the OCA CI log check treats as an error — failingtest with Odoo/test with OCBforfastapiand every module depending on it (e.g. #619).The 18.0 branch already uses
httpx2here; the change didn't carry over when 19.0 diverged. This restores it, unblocking the test CI for fastapi-dependent modules on 19.0.