Skip to content

[19.0][FIX] test-requirements: use httpx2 for starlette TestClient#620

Merged
rvalyi merged 1 commit into
OCA:19.0from
agiuseppe28:19.0-fix-test-requirements-httpx2
Jun 22, 2026
Merged

[19.0][FIX] test-requirements: use httpx2 for starlette TestClient#620
rvalyi merged 1 commit into
OCA:19.0from
agiuseppe28:19.0-fix-test-requirements-httpx2

Conversation

@agiuseppe28

Copy link
Copy Markdown

On 19.0, test-requirements.txt pins httpx, but starlette's TestClient in this stack imports httpx2 (import httpx2 as httpx). Without httpx2 installed, the TestClient falls back to httpx and emits a StarletteDeprecationWarning, which the OCA CI log check treats as an error — failing test with Odoo / test with OCB for fastapi and every module depending on it (e.g. #619).

The 18.0 branch already uses httpx2 here; the change didn't carry over when 19.0 diverged. This restores it, unblocking the test CI for fastapi-dependent modules on 19.0.

@agiuseppe28

Copy link
Copy Markdown
Author

@glitchov could you please approve? This would unlock several migrations. Thanks!

@rvalyi rvalyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, already httpx2 in 18.0 but as the files is not part of any Odoo module it was not carried to the 19.0 branch https://github.com/OCA/rest-framework/blob/18.0/test-requirements.txt#L2

@rvalyi

rvalyi commented Jun 22, 2026

Copy link
Copy Markdown
Member

trivial, fast tracking...

@rvalyi rvalyi merged commit fb38715 into OCA:19.0 Jun 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants