[19.0][MIG] fastapi_auth_api_key: Migration to 19.0#619
Open
agiuseppe28 wants to merge 12 commits into
Open
Conversation
OCA-git-bot
added
series:19.0
mod:fastapi_auth_api_key
agiuseppe28
force-pushed
the
19.0-mig-fastapi_auth_api_key
branch
from
4425e96 to
a0e53e1
Compare
Author
status.HTTP_422_UNPROCESSABLE_ENTITY is deprecated
Currently translated at 100.0% (5 of 5 strings) Translation: rest-framework-18.0/rest-framework-18.0-fastapi_auth_api_key Translate-URL: https://translation.odoo-community.org/projects/rest-framework-18-0/rest-framework-18-0-fastapi_auth_api_key/it/
Currently translated at 100.0% (5 of 5 strings) Translation: rest-framework-18.0/rest-framework-18.0-fastapi_auth_api_key Translate-URL: https://translation.odoo-community.org/projects/rest-framework-18-0/rest-framework-18-0-fastapi_auth_api_key/it/
agiuseppe28
force-pushed
the
19.0-mig-fastapi_auth_api_key
branch
from
a0e53e1 to
16e8ee3
Compare
Author
|
Current 19.0 now includes the httpx2 test-requirements.txt fix from #620 so CI is now green. I also smoke tested the runboat build and the module installs cleanly on 19.0 with its deps (fastapi, auth_api_key, auth_api_key_group), the migrated auth_api_key_group_id field is present on the FastAPI Endpoint, and the FastAPI app boots and serves correctly on 19.0. The module's own auth dependencies remain covered by its unit tests (green). @mmequignon could you take a look when you have a moment? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
fastapi_auth_api_keyto 19.0.History-preserving migration (
git format-patch | git amfrom 18.0). The[MIG]commit:19.0.1.0.0Partner->ResPartner(Odoo 19 model-class rename) in the type hints ofdependencies.pydependencies.py:env._("...") % {...}->env._("...", HTTP_API_KEY_HEADER=...)(fixestranslation-not-lazy)server-auth19.0:auth.api.key._retrieve_api_keynow quotes the key (The key '404' is not allowed)Dependencies available on 19.0:
fastapi(this repo) andauth_api_key_group(server-auth).Tests pass locally (7/7) on a fresh 19.0 database with demo data.
This module was not in the checklist of #567 (it landed on 18.0 in #568 after that issue was generated).
cc @mmequignon (maintainer)