Android: Sleep screen — in-app bed/wake time editing with live metric recompute

[ujix]

What this PR does

Executive summary: Adds in-app editing of bed and wake times from the Sleep nav header — an AlertDialog selects which time to edit, a TimePickerDialog sets the new value, and all metrics recompute instantly against the edited window with no DB round-trip wait.

Details:

Sleep screen — time editing

• Added: Tapping the edit icon in NightNavHeader opens a Strand-styled AlertDialog with two rows (Bedtime / Wake-up), each showing the current time and an accent edit icon; choosing either row opens its own TimePickerDialog
• Fixed: After confirming a change the header clock re-renders immediately via an optimistic in-memory sleeps list update; no DB round-trip wait required
• Fixed: Stage Breakdown subtitle derives "X in bed" from session.endTs − session.startTs so it reflects the edited window instantly rather than the stale stored value
• Fixed: All metrics (Rest %, Hours vs Needed, Sleep Debt, trend chart) recompute against the edited window: buildSleepModel now builds a metricsWindow that substitutes sessionDurationMin for the selected night's totalSleepMin, while keeping typicalTotalMin from the unmodified historical window

Data layer

• Added: WhoopDao.deleteSleepSession(deviceId, startTs) — @Query DELETE used as part of the delete-then-upsert update pattern
• Added: WhoopRepository.updateSleepSessionTimes(session, newStartTs, newEndTs) — deletes the old row and upserts the corrected copy
• Added: AppViewModel.updateSleepSessionTimes — thin suspend wrapper with runCatching so a DB error never surfaces as an unhandled exception

Validation: :app:assembleFullDebug, testFullDebugUnitTest, and testDemoDebugUnitTest all green.

Type of change

• Bug fix
• New feature
• Refactor / cleanup
• Documentation
• CI / tooling

How it was tested

Android 16. Real Samsung device. WHOOP 4.0. Tested: editing bed time independently, editing wake time independently, both in the same session, header clock updates immediately, all metric cards reflect edited duration, navigation position preserved after edit, data persists across app restart.

Checklist

• Swift package tests pass for any package I touched (swift test in Packages/<name>)
• Android unit tests pass if I touched android/ (./gradlew testFullDebugUnitTest)
• No new build warnings introduced
• UI changes use only StrandDesign tokens — no hardcoded colors, fonts, or spacing
• No hardcoded hex frame bytes; protocol facts live in the schema / decoders
• Follows the conventions in docs/CONTRIBUTING.md
• I did not commit generated output (Strand.xcodeproj/) or any secrets/keystores

Related issues

[NoopApp]

This is genuinely impressive work — and it's the one PR in this set that's a product-direction call, not a code-review call, so I want to flag it honestly rather than quietly fold it in.

In-app editing of recorded bed/wake times touches a core NOOP promise: your data is yours, on-device, and correctable. Letting people fix a mis-detected night fits that ethos well. But it also means the app now lets you rewrite recorded sleep, and it adds a DELETE path to the sleep store — so it deserves a deliberate yes, plus a plan to bring the same capability to iOS/macOS (which have no sleep editing today) so the platforms don't diverge on something this central.

The implementation itself is solid: delete-then-upsert is safe and backward-compatible, the optimistic in-memory update avoids UI lag with the DB write wrapped in runCatching, and buildSleepModel correctly substitutes the edited duration so the metrics recompute consistently.

So: holding this open as the canonical version of your Sleep-screen series. If we go ahead, it supersedes #258/#259 (same analytics cards, without the editing). I'll come back with a decision. Two small notes for whenever it lands: the analytics chart uses a hardcoded android.graphics.Color.argb(...) gray — we'd swap that for a Palette token to keep the no-hardcoded-color rule — and the chart elements could use contentDescription labels. Thank you for this.

[ujix]

Both issues addressed:

• Hardcoded color: Palette.textTertiary.toArgb() fix propagates from Android: Sleep screen — Hours vs Needed and Sleep Consistency analytics cards #258 through the rebased stack — no raw argb() calls remain.
• Chart contentDescription labels: all three chart elements now carry accessibility labels via Modifier.semantics { contentDescription = "..." }:
  • Hours vs Needed progress bar: "Hours vs Needed progress chart"
  • 14-day sleep hours trend LineChart: "Sleep hours trend chart"
  • Sleep Consistency nightly bar chart (Canvas): "Sleep Consistency nightly chart"

On the product-direction point — fully understood, and appreciate the honest framing. The delete-then-upsert data path and the iOS/macOS parity question are real considerations worth deliberating. Happy to wait on that call.

Branch updated and force-pushed.

[NoopApp]

Thanks — Palette.textTertiary.toArgb() across the rebased stack plus the chart contentDescription labels both look right, so the code nits are cleared. Just to be clear about what's holding this open: it isn't the code — it's the product decision I flagged. In-app editing of recorded sleep, plus the new DB delete path, is a trust/honesty call for the maintainer, and it needs an iOS/macOS parity plan since those platforms have no sleep editing today. That's the deliberate yes we need; the implementation itself is in good shape. Keeping it open for that call.

[NoopApp]

Adopted ✅ — the Sleep-screen umbrella shipped in v2.9.0: in-app bed/wake editing with live recompute, Hours-vs-Needed + Consistency cards, night navigation, detail sheets. Re-authored under the project account (hardcoded paint swapped for a Palette token, a11y labels added). Thanks @ujix — this was a big one! Closing as adopted.