Android: Sleep screen — metric detail ModalBottomSheet#259
Closed
ujix wants to merge 3 commits into
Closed
Conversation
…ckerDialog Redesigns NightNavHeader to match DayNavBar: left/right chevrons flanking an accent-tinted center block showing the night label and date. The time range moves to a separate row below. Tapping the block opens a DatePickerDialog to jump to any recorded night by calendar date. Also fixes nightOffset reset: moves it into LaunchedEffect(days) so it only resets on a real sync/import, not on every optimistic sleeps update.
12 tasks
12 tasks
Owner
|
Nice work — the metric-detail
This is the third rung of the Sleep stack and a subset of #260's surface, so same as #258: we're making one decision on #260 rather than merging the intermediate states. Holding open. Thanks for the thorough build-out. |
… card HoursVsNeededCard: score %, trend arrow, gradient progress bar, stacked component bar (Healthy / Strain / Debt), slept/needed/debt footer. SleepConsistencyCard: Canvas vertical bar chart (bed-time top, wake-time bottom), dashed typical overlay lines, Y-axis time labels, X-axis day labels. Score is count-based (nights where both bed and wake are within 45 min of the user's typical); the previous SD formula always returned 0 %.
ujix
force-pushed
the
android/sleep-metric-sheets
branch
2 times, most recently
from
bce2c87 to
ee5f57c
Compare
Each SparkTile in MetricGrid now accepts an onClick lambda; tapping any tile sets detailMetricKey and slides up a ModalBottomSheet scoped to SleepScreen. SparkTile gains an onClick param — when set, the card modifier gets .clickable so the whole tile is the touch target. AppRoot adds SleepMetricDetail as a nav destination (kept for deep-link compatibility). MainActivity adds KEY_LAST_JOURNAL_PROMPT to NoopPrefs.
ujix
force-pushed
the
android/sleep-metric-sheets
branch
from
ee5f57c to
b6bce17
Compare
12 tasks
Author
|
Both issues addressed:
Branch updated and force-pushed. |
Owner
|
Thanks — |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Executive summary: Tapping any metric tile in Sleep Night Detail now slides up a
ModalBottomSheetwith a full trend chart and range selector instead of pushing a new screen.Details:
Sleep screen — metric detail
ModalBottomSheet— W / M / 3M / 6M / 1Y / ALL range selector, Y-axis labels, interactiveLineChart, X-axis dates, min/avg/max footerSparkTileaccepts an optionalonClick: (() -> Unit)?parameter; when provided the tile renders with aclickablemodifier; when null it is non-interactive (backwards compatible)AppRootandMainActivitywired to surface the bottom sheet callback through the nav graphValidation:
:app:assembleFullDebug,testFullDebugUnitTest, andtestDemoDebugUnitTestall green.Type of change
How it was tested
Android 16. Real Samsung device. WHOOP 4.0. Tested: all 8 metric tiles open correct sheet, range selector switches data, chart drag shows values, sheet dismisses on swipe-down and back gesture, sheet does not open for non-clickable tiles.
Checklist
swift testinPackages/<name>)android/(./gradlew testFullDebugUnitTest)StrandDesigntokens — no hardcoded colors, fonts, or spacingdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues