Repository navigation
Record that immutable releases depend on the project - #480
Merged
Merged
Conversation
…nerate its copies
There was a problem hiding this comment.
🤖 NCode Review at 9752197: 4 new findings on the changed lines.
|
Superseded by the review at e08c769. |
Collaborator
Author
|
/review |
|
Superseded by the review at 135a959. |
Collaborator
Author
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at e08c769: 3 hunks in 2 files, by correctness only. Earlier findings: F1 fixed. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.04 on Amazon Bedrock, 10s, at 135a959. (how to interact) 📋 OutcomesMerged at 135a959: 4 fixed, 0 dismissed, 0 acknowledged, 0 ignored.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-0028 records the decision for #393: whether a GitHub project's releases are immutable depends on the project, not the template. A project whose releases get files or attestations after they are published, such as a .NET library through
release-provenance.yml, keeps mutable releases. Every other project gets immutable ones fromtools/Set-RepositoryBaseline.ps1. The record also says whytag-release.ymldoesn't draft each release forpublish.ymlto publish. ADR-0139 anddocs/adopt.mdlink to the decision.It also fixes two follow-ups. ADR-0020's Signed-Releases rows, ADR-0028 and
/best-practicesnow describe how Scorecard v5.7.0 scores releases: it counts only releases with assets, and among those an immutable release scores 10, the same as one with a*.intoto.jsonlfile. ADR-0020's library rows now depend on thenuget_publisheranswer, andtests/Test-Template.ps1checks all three renderings.scorecard.ymlnow pinsossf/scorecard-actionv2.6.0, which runs Scorecard v5.7.0. v2.6.0 is under three days old, so the pin uses ADR-0009's commented exception, and #481 removes the comment after 2026-11-22.Protected paths changed:
.claude/commands/best-practices.md
.github/prompts/best-practices.prompt.md
.github/skills/best-practices/SKILL.md
template/.claude/commands/best-practices.md
template/.github/prompts/best-practices.prompt.md
template/.github/skills/best-practices/SKILL.md
template/.github/workflows/scorecard.yml
Release: v0.111.4
Closes #393