Skip to content

Record that immutable releases depend on the project - #480

Merged
polewskm merged 15 commits into
mainfrom
worktree-issue-393
Nov 22, 2026
Merged

polewskm merged 15 commits into
mainfrom
worktree-issue-393

Conversation

@polewskm

@polewskm polewskm commented Nov 22, 2026 •

Copy link
Copy Markdown
Collaborator

ADR-0028 records the decision for #393: whether a GitHub project's releases are immutable depends on the project, not the template. A project whose releases get files or attestations after they are published, such as a .NET library through release-provenance.yml, keeps mutable releases. Every other project gets immutable ones from tools/Set-RepositoryBaseline.ps1. The record also says why tag-release.yml doesn't draft each release for publish.yml to publish. ADR-0139 and docs/adopt.md link to the decision.
It also fixes two follow-ups. ADR-0020's Signed-Releases rows, ADR-0028 and /best-practices now describe how Scorecard v5.7.0 scores releases: it counts only releases with assets, and among those an immutable release scores 10, the same as one with a *.intoto.jsonl file. ADR-0020's library rows now depend on the nuget_publisher answer, and tests/Test-Template.ps1 checks all three renderings.
scorecard.yml now pins ossf/scorecard-action v2.6.0, which runs Scorecard v5.7.0. v2.6.0 is under three days old, so the pin uses ADR-0009's commented exception, and #481 removes the comment after 2026-11-22.

Protected paths changed:
.claude/commands/best-practices.md
.github/prompts/best-practices.prompt.md
.github/skills/best-practices/SKILL.md
template/.claude/commands/best-practices.md
template/.github/prompts/best-practices.prompt.md
template/.github/skills/best-practices/SKILL.md
template/.github/workflows/scorecard.yml

Release: v0.111.4
Closes #393

@polewskm
polewskm deployed to code-review November 22, 2026 00:49 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 9752197: 4 new findings on the changed lines.

Comment thread tests/Test-Template.ps1 Resolved
@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Superseded by the review at e08c769.

@polewskm polewskm self-assigned this Nov 22, 2026
@polewskm
polewskm marked this pull request as ready for review November 22, 2026 01:08
@polewskm
polewskm deployed to code-review November 22, 2026 01:08 — with GitHub Actions Active
@polewskm

Copy link
Copy Markdown
Collaborator Author

/review

@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Superseded by the review at 135a959.

@polewskm

Copy link
Copy Markdown
Collaborator Author

/review

@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at e08c769: 3 hunks in 2 files, by correctness only. Earlier findings: F1 fixed. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.04 on Amazon Bedrock, 10s, at 135a959. (how to interact)

📋 Outcomes

Merged at 135a959: 4 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 hygiene, intent, rule-check 🟠 Should fix ✅ fixed
F2 tests, rule-check 🟠 Should fix ✅ fixed
F3 rule-check 🟡 Nit ✅ fixed
F4 rule-check 🟡 Nit ✅ fixed

@polewskm
polewskm enabled auto-merge November 22, 2026 01:53
@polewskm
polewskm merged commit 9aa5ac0 into main Nov 22, 2026
67 checks passed
@polewskm
polewskm deleted the worktree-issue-393 branch November 22, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide on immutable releases

1 participant