Skip to content

Report the adoption checklist with a read-only script - #479

Merged
polewskm merged 41 commits into
mainfrom
worktree-issue-471
Nov 22, 2026
Merged

polewskm merged 41 commits into
mainfrom
worktree-issue-471

Conversation

@polewskm

Copy link
Copy Markdown
Collaborator

Adds tools/Get-AdoptionChecklist.ps1 -Path <clone>, which runs all 34 rows of docs/adopt.md's Checklist for one adopted repository. It reads through the clone, gh or glab, and the -WhatIf runs of the baseline, GitLab baseline and Scorecard scripts, and changes nothing. It prints each row as done, not done, unreadable (naming the web page for rows only a page shows) or does not apply, then a count of each, and exits 1 when a row is not done.
Its suite, tests/Test-AdoptionChecklist.ps1, runs the checker against stand-ins for gh, glab and the sibling scripts on GitHub, private and GitLab fixtures. It also ties the checker's rows to the documented table, and CI runs it.
The tool is PowerShell 7 under ADR-0021's glue rule. It is named Get-AdoptionChecklist.ps1 because tests/Test-Adoption.ps1 already exists. Row 1.3 reads the node on PATH and nvs's installed releases rather than running Use-Node.ps1, which can install Node.js.
docs/adopt.md, README.md and CHANGELOG.md (v0.112.0) name the checker.

Protected paths changed:
.github/workflows/test-template.yml

Release: v0.112.0
Closes #471

@polewskm polewskm self-assigned this Nov 22, 2026
@polewskm
polewskm marked this pull request as ready for review November 22, 2026 00:09
@polewskm
polewskm deployed to code-review November 22, 2026 00:09 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 33884ba: 21 new findings on the changed lines.

Comment thread tools/Get-AdoptionChecklist.ps1 Resolved
Comment thread tools/Get-AdoptionChecklist.ps1 Resolved
Comment thread tests/Test-AdoptionChecklist.ps1 Resolved
Comment thread tools/Get-AdoptionChecklist.ps1 Resolved
Comment thread tools/Get-AdoptionChecklist.ps1 Resolved
Comment thread tests/Test-AdoptionChecklist.ps1 Resolved
Comment thread tools/Get-AdoptionChecklist.ps1 Resolved
Comment thread tools/Get-AdoptionChecklist.ps1 Resolved
Comment thread tools/Get-AdoptionChecklist.ps1 Resolved
Comment thread tools/Get-AdoptionChecklist.ps1 Resolved
@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Superseded by the review at 6a3c226.

@polewskm

Copy link
Copy Markdown
Collaborator Author

/review

@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Superseded by the review at b86720a.

@polewskm

Copy link
Copy Markdown
Collaborator Author

Autopilot: as far as this run can tell, this pull request is ready to merge.

Why:

  • Round 1 pushed 13 fix steps (33884ba..6a3c226) for NCode Review's 21 findings on 33884ba.
  • Fixed (17): F1, F3–F9, F11–F18 and F20.
  • Declined (3), each with its reason on its thread:
    • F2: gitsign exits 1 for every error, so a mismatch can't be told from an outage.
    • F19: inline limits are the repository's style.
    • F21: \d and $ match the template's own version parsing, which the new F12 check ties to.
  • Answered (1): F10, no timeout by design for an audit a person runs.
  • NCode Review's re-review of 6a3c226 found nothing new.
  • Nothing was put to the maintainer. No item asked to change a protected path.

Every thread below is still unresolved, so resolve each before you merge:

Merge with a merge commit or by rebasing, not by squashing, so the plan's step commits stay on main. Any comment after this one is still judged, fixed and answered while this run checks the pull request.

@polewskm

Copy link
Copy Markdown
Collaborator Author

/review

@polewskm

Copy link
Copy Markdown
Collaborator Author

Autopilot: round 2 (6a3c226..b86720a) fixes the findings that were declined or answered in round 1 (F2, F10, F19, F21), at the maintainer's request. It also resolves the merge conflict with main:

  • Merge: step 10 (69a5c82) merges origin/main in after Record that immutable releases depend on the project #480 released v0.111.4. 0.112.0 now sits above 0.111.4 in CHANGELOG.md, and the two entries 0.111.4 already released are gone from 0.112.0.
    • Because the branch now holds that merge, this pull request must merge with a merge commit, not by rebasing.
  • Protected paths changed: add template/.template/Get-TemplateUpdate.ps1 to the description's list. It changed on lines 45 and 107–109 only, for F21, with the maintainer's approval. With .github/workflows/test-template.yml already listed, those are the protected paths this pull request changes.

@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 6a3c226: 6 hunks in 4 files and changes taken back in 3 files, by correctness only. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.18 on Amazon Bedrock, 17s, at b86720a. (how to interact)

📋 Outcomes

Merged at b86720a: 21 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 rule-check, conventions 🟠 Should fix ✅ fixed
F2 rule-check 🟠 Should fix ✅ fixed
F3 rule-check 🟠 Should fix ✅ fixed
F4 tests 🟠 Should fix ✅ fixed
F5 tests 🟠 Should fix ✅ fixed
F6 rule-check 🟠 Should fix ✅ fixed
F7 tests 🟠 Should fix ✅ fixed
F8 rule-check 🟠 Should fix ✅ fixed
F9 tests 🟠 Should fix ✅ fixed
F10 rule-check 🟡 Nit ✅ fixed
F11 correctness 🟡 Nit ✅ fixed
F12 architecture, hygiene 🟡 Nit ✅ fixed
F13 rule-check 🟡 Nit ✅ fixed
F14 rule-check 🟡 Nit ✅ fixed
F15 tests 🟡 Nit ✅ fixed
F16 rule-check 🟡 Nit ✅ fixed
F17 rule-check 🟡 Nit ✅ fixed
F18 rule-check 🟡 Nit ✅ fixed
F19 rule-check 🟡 Nit ✅ fixed
F20 rule-check 🟡 Nit ✅ fixed
F21 rule-check 🟡 Nit ✅ fixed

@polewskm

Copy link
Copy Markdown
Collaborator Author

Autopilot: as far as this run can tell, this pull request is ready to merge at b86720a.

Why:

  • Round 1 (33884ba..6a3c226) fixed 17 of NCode Review's 21 findings.
  • Round 2 (6a3c226..b86720a), at the maintainer's request, fixed the four that round 1 had declined or answered: F2, F10, F19 and F21. It also fixed this run's own review nits and merged main in to resolve the CHANGELOG.md conflict with v0.111.4.
  • All 21 findings are now fixed, and nothing is put to the maintainer.
  • NCode Review's re-review of b86720a approves with no findings, and GitHub reports the pull request as mergeable.

Before you merge:

Any comment after this one is still judged, fixed and answered while this run checks the pull request.

@polewskm
polewskm merged commit f5a6c7b into main Nov 22, 2026
68 checks passed
@polewskm
polewskm deleted the worktree-issue-471 branch November 22, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report the adoption checklist with a read-only script

1 participant