feat: refine external player settings and selective routing options#510
Open
mattsigal wants to merge 1 commit into
Open
feat: refine external player settings and selective routing options#510mattsigal wants to merge 1 commit into
mattsigal wants to merge 1 commit into
Conversation
- Centrally filter out system stubs (e.g. Gallery and lightbox) in ExternalPlayerService. - Decouple "External player app" preference tile configuration from "Use external player" toggle. - Style the "External player app" tile with focus highlighting and an option selection bubble. - Hide the "Open in External Player" advanced play option when no player is configured. - Route direct launches to the configured external player (e.g. VLC) immediately without the app chooser. - Skip cinema mode prerolls during external player playback routing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up External Player Behaviours
Summary
Refines the settings representation and conditional routing logic for external media players.
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
ExternalPlayerService.listPlayersto omit system stubs (Gallery, Lightbox, etc.) from picker dialog and launching.TvFocusHighlightand selection bubbles on the right.Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Include screenshots or recordings for UI changes.
With an external player chosen:

Without an external player chosen:

Checklist