Skip to content

fix: resolve current episode highlight color and focus clash#499

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:bugfix/current-episode-highlight
Jun 11, 2026
Merged

fix: resolve current episode highlight color and focus clash#499
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:bugfix/current-episode-highlight

Conversation

@mattsigal

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Implements a visual theme-appropriate distinction for the "next up" episode card highlights.

Related Issues

Link related issues or tickets separated by commas.

  • Closes #
  • Fixes #
  • Related to #

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Modified _EpisodeListCardState.build in lib/ui/screens/detail/item_detail_screen.dart to check showFocusBorder first. Active focus highlights now cleanly override next-up borders.
  • Styled the next-up episode (widget.isCurrent when not focused) using AppColorScheme.onSurface (cyan in Neon Pulse, white in the default Moonfin theme)
  • Fixed outdated preference migration key assertions (pref_audio_preference_split_v1 -> v2) in audio_migration_test.dart to keep the test suite passing.

Platform

  • Android
  • iOS
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Navigate to a TV Series detail page in the Neon Pulse theme.
  2. Verify that the next-up episode card has a thicker, cyan outline when not focused.
  3. Move focus to the card and verify it scales and displays the primary pink focus border.

Screenshots (if applicable)

Original:
2026-06-11_08-19-36_moonfin

New (with both themes):
2026-06-11_08-34-32_moonfin

2026-06-11_08-34-15_moonfin

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan

Copy link
Copy Markdown
Contributor

rebase on main

- Prioritize active focus highlights over the next-up episode card border.
- Style the next-up episode border using AppColorScheme.onSurface (cyan in Neon Pulse, white in Moonfin) with a thicker width of 2.5.
- Update preference migration keys in unit tests from v1 to v2 to align with main branch implementation.
@mattsigal mattsigal force-pushed the bugfix/current-episode-highlight branch from 1e49ad7 to 1a44e39 Compare June 11, 2026 21:51
@RadicalMuffinMan RadicalMuffinMan merged commit d63da3a into Moonfin-Client:main Jun 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants