fix: resolve current episode highlight color and focus clash#499
Merged
RadicalMuffinMan merged 1 commit intoJun 11, 2026
Merged
Conversation
Contributor
|
rebase on main |
- Prioritize active focus highlights over the next-up episode card border. - Style the next-up episode border using AppColorScheme.onSurface (cyan in Neon Pulse, white in Moonfin) with a thicker width of 2.5. - Update preference migration keys in unit tests from v1 to v2 to align with main branch implementation.
1e49ad7 to
1a44e39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Implements a visual theme-appropriate distinction for the "next up" episode card highlights.
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
_EpisodeListCardState.buildinlib/ui/screens/detail/item_detail_screen.dartto checkshowFocusBorderfirst. Active focus highlights now cleanly override next-up borders.widget.isCurrentwhen not focused) usingAppColorScheme.onSurface(cyan in Neon Pulse, white in the default Moonfin theme)pref_audio_preference_split_v1->v2) inaudio_migration_test.dartto keep the test suite passing.Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Original:

New (with both themes):

Checklist