Skip to content

Commit 1e49ad7

Browse files
committed
fix: resolve current episode highlight color and focus clash
- Prioritize active focus highlights over the next-up episode card border. - Style the next-up episode border using AppColorScheme.onSurface (cyan in Neon Pulse, white in Moonfin) with a thicker width of 2.5. - Update preference migration keys in unit tests from v1 to v2 to align with main branch implementation.
1 parent bcc36b8 commit 1e49ad7

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

lib/ui/screens/detail/item_detail_screen.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8937,18 +8937,18 @@ class _EpisodeListCardState extends State<_EpisodeListCard>
89378937
width: widget.isMobile ? 180.0 : 220.0 * desktopScale,
89388938
decoration: BoxDecoration(
89398939
borderRadius: BorderRadius.circular(8),
8940-
border: widget.isCurrent
8940+
border: showFocusBorder
89418941
? Border.fromBorderSide(
89428942
ThemeRegistry.active.borders.focusBorder.copyWith(
8943-
color: AppColorScheme.accent,
8944-
width: 2,
8943+
color: isNeon ? AppColorScheme.accent : focusColor,
8944+
width: 1.5,
89458945
),
89468946
)
8947-
: showFocusBorder
8947+
: widget.isCurrent
89488948
? Border.fromBorderSide(
89498949
ThemeRegistry.active.borders.focusBorder.copyWith(
8950-
color: isNeon ? AppColorScheme.accent : focusColor,
8951-
width: 1.5,
8950+
color: AppColorScheme.onSurface,
8951+
width: 2.5,
89528952
),
89538953
)
89548954
: null,

test/preference/audio_migration_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ void main() {
4747
store.getString(UserPreferences.audioFallbackCodec.key),
4848
AudioFallbackCodec.aacStereo.name,
4949
);
50-
expect(store.getBool('pref_audio_preference_split_v1'), isTrue);
50+
expect(store.getBool('pref_audio_preference_split_v2'), isTrue);
5151
});
5252

5353
test('does not overwrite split values when already present', () async {
@@ -77,7 +77,7 @@ void main() {
7777
expect(store.containsKey(UserPreferences.eac3PassthroughEnabled.key), isFalse);
7878
expect(store.containsKey(UserPreferences.dtsCorePassthroughEnabled.key), isFalse);
7979
expect(store.containsKey(UserPreferences.trueHdPassthroughEnabled.key), isFalse);
80-
expect(store.getBool('pref_audio_preference_split_v1'), isTrue);
80+
expect(store.getBool('pref_audio_preference_split_v2'), isTrue);
8181
});
8282
});
8383
}

0 commit comments

Comments
 (0)