Unit selector G/P option

[SJuliez]

This moves the unit selector gunnery/piloting toggle directly into the unit selector where it is used exclusively and removes it from the GUI settings, see below. The G/P toggle still saves its state to the client preferences, so the unit selector will remember the latest setting.

Other changes:

• moved the G/P fields down and into a single line that is hidden when G/P is turned off
• internal changes to how they are read; when the value is illegal, they show a red error border
• when G/P is turned off, the values reset to 4/5 so that there is no hidden BV multiplier
• the shown unit count is now updated also when first showing the unit selector
• bit of cleanup of code repetition

[codecov]

Codecov Report

❌ Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.99%. Comparing base (ebc0fbd) to head (b937de9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...nitSelectorDialogs/AbstractUnitSelectorDialog.java	0.00%	53 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8289      +/-   ##
============================================
- Coverage     30.00%   29.99%   -0.01%     
+ Complexity    17927    17915      -12     
============================================
  Files          3199     3199              
  Lines        311610   311606       -4     
  Branches      54369    54364       -5     
============================================
- Hits          93492    93477      -15     
- Misses       208420   208455      +35     
+ Partials       9698     9674      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[psikomonkie]

One change needed: Copyright on CommonSettingsDialog. Everything code wise looks great & I'm otherwise ready to approve.

I love learning about a feature by seeing a PR where it's replaced by a better version!!

This looks fantastic. The caveats about the old implementation just make it seem so... Unhelpful. This is such a good change that I can see myself using. Thank you!

[psikomonkie]

Copyright