Repository navigation
tests: drop the xfail marker and its runtests support - #4544
Merged
Merged
Conversation
A test marked xfail could never fail the run: a failure counted as expected and a pass printed XPASS. The only user, interp/m98m99/12-M99-endless-main-program, got the marker in 2022 for a shutdown race (LinuxCNC#857) that 7ba944c fixed in 2025. The stale marker then hid the output change from LinuxCNC#4441 (LinuxCNC#4537, fixed in LinuxCNC#4540). The test passes 40 of 40 runs under CPU stress here. Remove the marker and the xfail handling. A test that wants a negative result negates it itself, as tests/overrun does; its checkresult and README follow the new summary line. The failure label goes back to FAIL. Fixes LinuxCNC#4537 Fixes LinuxCNC#857
BsAtHome
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
xfailmarker fromtests/interp/m98m99/12-M99-endless-main-programand the xfail handling fromruntests.The marker meant the test could never fail the run: a failure counted as expected, a pass printed
XPASS. It was added in 2022 for the shutdown race in #857, which 7ba944c fixed in 2025; the test has passed since. The stale marker is what hid the output change from #4441 until #4537 (fixed by #4540).I ran the test 40 times under CPU stress (2x oversubscribed cores with IO churn, then pinned to one core with six busy loops): 40 of 40 pass.
With the handling gone, a failing test always fails the run. A test that wants a negative result negates it itself, as
tests/overrunalready does; itscheckresultgrep and README follow the new summary line. The failure label goes back toFAIL:(it has printedXFAIL:for every failure since the marker was added).Fixes #4537
Fixes #857