Repository navigation
perf(transaction): resolve a node's local row with one local-table lookup - #1155
Merged
adsharma merged 1 commit intoOct 9, 2026
Merged
Conversation
…okup Checking whether a node offset is uncommitted and then computing its local row index looked up the transaction's local table up to three times per row, once in isUnCommitted and again in each getLocalRowIdx call. Node table lookups and scan-state setup pay this per row on point lookups. tryGetLocalRowIdx returns the local row index, or nothing when the offset is committed, from a single getLocalTable call, and NodeTable's initScanState, lookup, and lookupMultiple use it in place of the pair.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Node-table point lookups check whether an offset is uncommitted with
Transaction::isUnCommittedand then compute its local row withgetLocalRowIdx. Each of those calls looks up the transaction's local table again, solookupMultiplepays up to three lookups per row.Transaction::tryGetLocalRowIdxanswers both from onegetLocalTablecall: it returns the row's index in the local table, or nothing when the offset is committed.NodeTable::initScanState,lookupandlookupMultiplenow use it, with no change in behavior.The vector extension's
OnDiskEmbeddings::getEmbeddingmakes the same pair of calls on every embedding read (raised on LadybugDB/extensions#95) and can switch to the helper once this lands.Types of changes