Repository navigation
fix(vector): read on-disk embeddings through the scan state's transaction - #101
Merged
adsharma merged 1 commit intoOct 9, 2026
Merged
Conversation
Contributor
|
Follow-ups (non-blocking, reviewed pr95..pr101):
|
…tion OnDiskEmbeddings::constructScanState accepts a transaction that overrides the one the embeddings were built with, but getEmbedding and getEmbeddings ignored it: visibility, the committed/uncommitted source, scan-state setup, and the lookup all used the member transaction. A caller passing a different transaction would read visibility from one transaction and rows from another. OnDiskEmbeddingScanState now keeps the transaction it was constructed with, and both lookup paths use it, matching how the cached quantized embeddings already resolve visibility.
adsharma
force-pushed
the
fix/vector-scan-state-transaction
branch
from
October 9, 2026 18:22
268136a to
1ed269e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnDiskEmbeddings::constructScanStatetakes an optional transaction that overrides the one the embeddings were built with, butgetEmbeddingandgetEmbeddingsignored it and used the member transaction for visibility, the committed/uncommitted source, scan-state setup and the lookup. A caller passing a different transaction would get visibility from one transaction and rows from another. Every current caller passes the same transaction, so nothing changes today.OnDiskEmbeddingScanStatenow keeps the transaction it was built with, and both lookup paths read through it, the same way the cached quantized embeddings already resolve visibility.Depends on #95 and should merge after it; the first commit here is #95's. Like #95, CI builds against the latest successful core Build and Deploy run on
main, which predates LadybugDB/ladybug#1113, so it won't compile until that workflow next succeeds.