Repository navigation
build: generate lbug.hpp for source builds - #41
Merged
Merged
Conversation
adsharma
added a commit
to LadybugDB/ladybug
that referenced
this pull request
Sep 26, 2026
Depends on LadybugDB/ladybug-rust#41. Fixes the deploy-rust failure (fatal error: lbug.hpp) when building from source.
adsharma
added a commit
to LadybugDB/ladybug
that referenced
this pull request
Sep 26, 2026
Depends on LadybugDB/ladybug-rust#41. Fixes the deploy-rust failure (fatal error: lbug.hpp) when building from source.
adsharma
added a commit
to LadybugDB/ladybug
that referenced
this pull request
Sep 26, 2026
Depends on LadybugDB/ladybug-rust#41. Fixes the deploy-rust failure (fatal error: lbug.hpp) when building from source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The partition routing shim (src/lbug_partition_routing.cpp) includes <lbug.hpp>, but build_bundled_cmake() configured CMake with BUILD_SINGLE_FILE_HEADER=OFF, so from-source builds (e.g. deploy-rust with LBUG_RUST_BUILD_FROM_SOURCE=1) failed with 'fatal error: lbug.hpp: No such file or directory'. Generate the amalgamated header for source builds. It lands in /src, which is already on the include path.