Remove implicit sequential dependency from typed action#369
Remove implicit sequential dependency from typed action#369adam-cattermole wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesTyped Action Dependency Isolation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b6be387 to
7b6d940
Compare
2e28744 to
635e3f8
Compare
7b6d940 to
fd9455e
Compare
Signed-off-by: Adam Cattermole <a.d.cattermole@gmail.com>
fd9455e to
9857fa6
Compare
| let dependencies = if i > 0 { | ||
| vec![(i - 1).to_string()] | ||
| } else { | ||
| vec![] | ||
| }; |
There was a problem hiding this comment.
This keeps the dependencies between legacy types but not for the new types.. but dependencies should disappear once we burn Legacy
DynamicTasks are treated as sequential implicitly rather than trusting the configuration to explicitly define dependence. Their onreply tasks also are tried to execute on response.. but then will enforce sequential ordering if requeued.
Once we migrate from legacy config we can remove the dependencies field entirely and have it explicitly defined.
Summary by CodeRabbit
Release Notes