Skip to content

Commit fd9455e

Browse files
Remove implicit sequential dependency from typed action
Signed-off-by: Adam Cattermole <a.d.cattermole@gmail.com>
1 parent 635e3f8 commit fd9455e

1 file changed

Lines changed: 9 additions & 13 deletions

File tree

src/kuadrant/pipeline/blueprint.rs

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -185,21 +185,21 @@ impl Blueprint {
185185
.enumerate()
186186
.map(|(i, action_config)| {
187187
let id = i.to_string();
188-
let dependencies = if i > 0 {
189-
vec![(i - 1).to_string()]
190-
} else {
191-
vec![]
192-
};
193188
match action_config {
194189
configuration::ActionConfig::Legacy(action) => {
190+
let dependencies = if i > 0 {
191+
vec![(i - 1).to_string()]
192+
} else {
193+
vec![]
194+
};
195195
let legacy_request_data: Vec<((String, String), String)> = request_data
196196
.iter()
197197
.map(|(key, expr)| (key.clone(), expr.source().to_string()))
198198
.collect();
199199
Action::compile(action, services, id, dependencies, &legacy_request_data)
200200
}
201201
configuration::ActionConfig::Typed(typed) => {
202-
Action::compile_typed(typed, services, id, dependencies)
202+
Action::compile_typed(typed, services, id, vec![])
203203
}
204204
}
205205
})
@@ -435,12 +435,7 @@ impl Action {
435435
.enumerate()
436436
.map(|(idx, typed_action)| {
437437
let reply_id = format!("{}.{}", id, idx);
438-
let reply_deps = if idx > 0 {
439-
vec![format!("{}.{}", id, idx - 1)]
440-
} else {
441-
vec![]
442-
};
443-
Action::compile_typed(typed_action, services, reply_id, reply_deps)
438+
Action::compile_typed(typed_action, services, reply_id, vec![])
444439
})
445440
.collect::<Result<_, _>>()?;
446441

@@ -1027,6 +1022,7 @@ mod tests {
10271022
assert!(matches!(service, ServiceInstance::Dynamic(_)));
10281023
assert_eq!(on_reply.len(), 1);
10291024
}
1030-
assert_eq!(blueprint.actions[1].dependencies, vec!["0"]);
1025+
1026+
assert!(blueprint.actions[1].dependencies.is_empty());
10311027
}
10321028
}

0 commit comments

Comments
 (0)