Skip to content

strncmp length correction #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charles-lunarg merged 1 commit into from
Jun 16, 2025
Merged

strncmp length correction #1729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions loader/loader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3705,9 +3705,8 @@ VkResult loader_parse_icd_manifest(const struct loader_instance *inst, char *fil

char *library_arch_str = loader_cJSON_GetStringValue(loader_cJSON_GetObjectItem(itemICD, "library_arch"));
if (library_arch_str != NULL) {
// cJSON includes the quotes by default, so we need to look for those here
if ((strncmp(library_arch_str, "32", 4) == 0 && sizeof(void *) != 4) ||
(strncmp(library_arch_str, "64", 4) == 0 && sizeof(void *) != 8)) {
if ((strncmp(library_arch_str, "32", 2) == 0 && sizeof(void *) != 4) ||
(strncmp(library_arch_str, "64", 2) == 0 && sizeof(void *) != 8)) {
loader_log(inst, VULKAN_LOADER_INFO_BIT, 0,
"loader_parse_icd_manifest: Driver library architecture doesn't match the current running "
"architecture, skipping this driver");
Expand Down