strncmp length correction

[1640max]

Double quotes in cJSON output were removed at bca23b3

They were also removed from those string literals, however the third strncmp's argument left unchanged, making the function to check beyond the string.

[ci-tester-lunarg]

Author 1640max not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author 1640max not on autobuild list. Waiting for curator authorization before starting CI build.

[CLAassistant]

All committers have signed the CLA.

[charles-lunarg]

Thanks for catching this! How did you find it if I may ask?

I can guess why I didn't, the tests don't write intentionally wrong arch strings so strncmp always returned before reading garbage.

[ci-tester-lunarg]

CI Vulkan-Loader build queued with queue ID 465912.

[ci-tester-lunarg]

CI Vulkan-Loader build # 3081 running.

[ci-tester-lunarg]

CI Vulkan-Loader build # 3081 passed.

[1640max]

I was trying a niche-specific code analyser—nothing noteworthy, to be honest.

I just realised that strncmp wouldn't actually reach the garbage since it never reads after \0. And if we're talking about intentionally wrong strings, it might make more sense to use 3 as the third argument instead.