docs(contributing): list the three CI-enforced gates omitted from Req…#1378
docs(contributing): list the three CI-enforced gates omitted from Req…#1378minion1227 wants to merge 4 commits into
Conversation
…uired Gates (JSONbored#1372) The Required Gates code block listed 10 of the commands `npm run test:ci` actually runs but omitted three CI-enforced ones: db:migrations:check, ui:version-audit, and ui:test. Add them in their real test:ci order so the documented local gate matches what CI enforces and contributors don't push a PR that passes the documented subset but fails CI on a gate they never ran.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Important Gittensory found maintainer review notesSame-issue duplicate risk found against #1373. Maintainers should resolve the overlap before review continues. Readiness score: 49/100
Signal definitions
Review context
Maintainer notes
Contributor next steps
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
JSONbored
left a comment
There was a problem hiding this comment.
Closing as plagiarism. The diff is byte-for-byte identical to #1373, which kiannidev filed nearly two hours earlier on this same issue. There's no independent work here — it's a verbatim copy re-filed under a second account to claim the credit. Lifting another contributor's open diff is a hard violation, not a near-miss. The original merges; this closes.
Summary
Closes #1372.
## Required Gatescode block inCONTRIBUTING.mdlisted 10 of the commandsnpm run test:ciactually runs but omitted three CI-enforced ones, so a contributor who ran only the documented list could pass it yet still fail CI on a gate they were never told to run.test:ciorder:npm run db:migrations:check(afteractionlint),npm run ui:version-audit(afterui:openapi:check), andnpm run ui:test(afterui:typecheck).package.json'stest:ciscript: the documented list now matches the enforced command set exactly, in order. Docs-only; no code, behavior, or generated artifact changes.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragenpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
CONTRIBUTING.md(one code fence, three added lines). It touches nosrc/**, test, build, OpenAPI, migration, or workflow file, so the code/test/build/coverage gates have nothing to exercise —CONTRIBUTING.mdis outside Codecov'ssrc/**scope (nocodecov/patchobligation) and outside every lint/typecheck path.git diff --checkwas run and is clean. The change was validated by diffing the documented list againstpackage.json'stest:ciscript (now an exact, in-order match). Per the Required Gates note, docs-only PRs may skip the gate with the skipped checks named here.Safety
UI Evidencesection below. (N/A — Markdown docs change, no rendered UI/screenshot surface.)CHANGELOG.mdis untouched.)UI Evidence
N/A — documentation-only change to
CONTRIBUTING.md; no UI, frontend, extension, or rendered-page surface.Notes
## Required Gatesfenced block; no surrounding prose changed.