docs(contributing): list the three CI-enforced gates the manual gate omitted#1373
Merged
JSONbored merged 4 commits intoJun 26, 2026
Merged
Conversation
…omitted The Required Gates command block is meant to mirror the combined gate (npm run test:ci), but it left out three commands that test:ci runs and that CI enforces, so contributors who followed it could still hit CI failures: - npm run db:migrations:check (CI lint job) - npm run ui:version-audit (CI ui job) - npm run ui:test (CI ui job) Add them in the same order as test:ci so the documented gate matches the actually enforced gate. Fixes JSONbored#1372 Co-authored-by: Cursor <cursoragent@cursor.com>
dosubot
Bot
added
the
size:XS
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
24 tasks
JSONbored
approved these changes
Jun 26, 2026
JSONbored
left a comment
JSONbored
left a comment
Owner
There was a problem hiding this comment.
First-filed and factually correct against test:ci and ci.yml. The doc now mirrors CI. Merge. For the record: an identical copy ([#1378 (https://github.com//issues/1378)) was filed ~2h later on the same issue by a different account — that one's the problem, not this.
This was referenced Jun 26, 2026
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Required Gates code block in
CONTRIBUTING.mdis meant to mirror the combined gate (npm run test:ci), but it omitted three commands thattest:ciruns and that CI enforces. A contributor who followed the documented gate literally would skip them and could still hit CI failures. This adds the missing commands in the same order they appear intest:ci.Added:
.github/workflows/ci.yml)npm run db:migrations:checklintjob — "Check migrations" stepnpm run ui:version-audituijob — "UI/MCP version audit" stepnpm run ui:testuijob — "UI tests" stepAfter this change the documented gate matches the 14-step
test:ciscript inpackage.json(plus the trailingnpm audit, as before).Why no screenshots
Docs-only change to a single Markdown file; there is no visible UI, frontend, or extension surface to capture.
Validation
Docs-only change: it touches only
CONTRIBUTING.md(no path matched by the CIbackend/ui/mcpfilters), so the code/test/build gates are not applicable to this diff. The whitespace gate (git diff --check) passes with no errors.Linked issue
Fixes #1372
Made with Cursor