[minor] Add allowInsecureArgs to yaml spec#164
Merged
Conversation
joecorall
added a commit
to Islandora-Devops/isle-buildkit
that referenced
this pull request
Nov 13, 2025
Member
Author
|
@t4k - have you had a chance to test this? |
|
Thanks for the prompt and the very helpful testing instructions. On my local I've uploaded a new Original File where the service file is resized (or not) properly both above and below my threshold. ✅ |
aOelschlager
approved these changes
Nov 26, 2025
aOelschlager
pushed a commit
to Islandora-Devops/isle-buildkit
that referenced
this pull request
Nov 26, 2025
* Build scyllaridae to allow easier testing * install go since alpine is on 1.24 * Allow testing Islandora/scyllaridae#164 * Add SCYLLARIDAE_ALLOW_INSECURE_ARGS * Update scyllaridae version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Allows
X-Islandora-Argsto contain insecure shell characters ifallowInsecureArgsinscyllaridae.ymlis set totrueHow should this be tested?
See Islandora-Devops/isle-buildkit#490
Documentation Status
Interested parties
@Islandora/committers @t4k