[minor] Add allowInsecureArgs to scyllaridae.yml#490
Merged
Conversation
e8c9bf6 to
99da5ca
Compare
since alpine is on 1.24
99da5ca to
de34f8d
Compare
f2a93b1 to
a4b1650
Compare
joecorall
commented
Nov 13, 2025
joecorall
commented
Nov 13, 2025
joecorall
commented
Nov 13, 2025
Contributor
|
I haven't had a chance to test this myself, but what I can see here looks good. Unfortunately, I won't be able to make the Tech Call today. |
Contributor
|
I've now tested this and it works great for my use case! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
allowInsecureArgsas an environment variable microservices can set to allow dangerous bash characters inX-Islandora-ArgsHTTP headers.How to test
Update your houdini service to use this PR's houdini image
Restart your service
Request a PNG from the service
file not createdshould print since there is an insecure bash argument inX-Islandora-Args(i.e.>)Update your houdini service to allow insecure args
Restart your service
Request a PNG from the service
file createdshould print even though there is an insecure bash argument inX-Islandora-Args(i.e.>).There should be a file on your system that's a 76x76 PNG