Skip to content

mono - chore: upgrade TypeScript and build tooling #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredwray merged 1 commit into from
Oct 8, 2026
Merged

mono - chore: upgrade TypeScript and build tooling #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
"@vitest/coverage-v8": "^5.0.3",
"rimraf": "^6.1.3",
"tsd": "^0.33.0",
"tsdown": "^0.22.2",
"typescript": "^6.0.3",
"tsdown": "^0.23.0",

@gemini-code-assist gemini-code-assist Bot Oct 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Upgrading tsdown to ^0.23.0 (which pulls in rolldown-plugin-dts@0.28.6) introduces stricter Node.js engine requirements: ^22.18.0 || ^24.11.0 || >=26.0.0. This is incompatible with the project's current engines.node definition (^22.18.0 || >=24.0.0), which permits Node.js versions in the [24.0.0, 24.11.0) and [25.0.0, 26.0.0) ranges. To prevent installation or runtime issues on unsupported Node.js versions, please update the engines.node field in package.json to match these new constraints.

@cursor cursor Bot Oct 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep engines.node at package.json:48. tsdown is a devDependency. Its engines field is at node_modules/tsdown/package.json:38. That field limits the Node version for the build. It does not limit the Node version for the published SDK. A copy of that range drops Node 24.0 through 24.10 and Node 25 for SDK users. This pull request does not change runtime code.

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match the Node range to tsdown 0.23

For Node 24.0 through 24.10, or Node 25, package.json permits the runtime, but tsdown 0.23.0 rejects it. Its lockfile engine is ^22.18.0 || ^24.11.0 || >=26.0.0, while this package declares ^22.18.0 || >=24.0.0. Installs can fail with strict engine checks, and the build cannot run on a declared supported runtime. Update the project engine range or retain compatible tooling.

Useful? React with 👍 / 👎.

@cursor cursor Bot Oct 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep tsdown at 0.23.0. See package.json:57. Do not change engines.node at package.json:48. tsdown 0.22.2 used the same engines range as this package. tsdown 0.23.0 uses a stricter range. tsdown is a devDependency. SDK users do not install it. This repo does not set engine-strict. CI builds on Node 22, 24, and 26, and those checks pass. A narrower engines.node drops Node 24.0 through 24.10 and Node 25 for SDK users. The Node version sources already disagree, so this pull request does not change them.

"typescript": "^7.0.2",
"vitest": "^5.0.3"
},
"files": [
Expand Down
Loading
Loading