Repository navigation
mono - chore: upgrade TypeScript and build tooling - #154
Conversation
Bump typescript to 7.0.2 and tsdown to 0.23.0. Keep @types/node at 22.20.1. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades tsdown to ^0.23.0 and typescript to ^7.0.2 in package.json, updating the lockfile accordingly. Feedback indicates that the upgraded tsdown dependency introduces stricter Node.js engine requirements that conflict with the project's current engines.node configuration, and it is recommended to update package.json to match these new constraints.
| "tsd": "^0.33.0", | ||
| "tsdown": "^0.22.2", | ||
| "typescript": "^6.0.3", | ||
| "tsdown": "^0.23.0", |
There was a problem hiding this comment.
Upgrading tsdown to ^0.23.0 (which pulls in rolldown-plugin-dts@0.28.6) introduces stricter Node.js engine requirements: ^22.18.0 || ^24.11.0 || >=26.0.0. This is incompatible with the project's current engines.node definition (^22.18.0 || >=24.0.0), which permits Node.js versions in the [24.0.0, 24.11.0) and [25.0.0, 26.0.0) ranges. To prevent installation or runtime issues on unsupported Node.js versions, please update the engines.node field in package.json to match these new constraints.
There was a problem hiding this comment.
Keep engines.node at package.json:48. tsdown is a devDependency. Its engines field is at node_modules/tsdown/package.json:38. That field limits the Node version for the build. It does not limit the Node version for the published SDK. A copy of that range drops Node 24.0 through 24.10 and Node 25 for SDK users. This pull request does not change runtime code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 639 639
Branches 151 146 -5
=========================================
Hits 639 639 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The review asks to copy the |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c60c0c5f53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "tsd": "^0.33.0", | ||
| "tsdown": "^0.22.2", | ||
| "typescript": "^6.0.3", | ||
| "tsdown": "^0.23.0", |
There was a problem hiding this comment.
For Node 24.0 through 24.10, or Node 25, package.json permits the runtime, but tsdown 0.23.0 rejects it. Its lockfile engine is ^22.18.0 || ^24.11.0 || >=26.0.0, while this package declares ^22.18.0 || >=24.0.0. Installs can fail with strict engine checks, and the build cannot run on a declared supported runtime. Update the project engine range or retain compatible tooling.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Keep tsdown at 0.23.0. See package.json:57. Do not change engines.node at package.json:48. tsdown 0.22.2 used the same engines range as this package. tsdown 0.23.0 uses a stricter range. tsdown is a devDependency. SDK users do not install it. This repo does not set engine-strict. CI builds on Node 22, 24, and 26, and those checks pass. A narrower engines.node drops Node 24.0 through 24.10 and Node 25 for SDK users. The Node version sources already disagree, so this pull request does not change them.
|
Codex asks to narrow |
2 participants
Summary
TypeScript moves from 6.0.3 to 7.0.2, and tsdown moves from 0.22.2 to 0.23.0.
@types/nodestays on 22.20.1. The Node sources do not name one major, so the type package stays on major 22.pnpmalready resolves 22.20.1 for that major.Changes
typescript6.0.3 → 7.0.2.tsdown0.22.2 → 0.23.0.Artifact diffs
Verification
pnpm buildpasses.pnpm exec biome check --error-on-warningspasses.HYPHEN_API_KEYandHYPHEN_PUBLIC_API_KEYerrors (52 failed, 241 passed, 2 skipped).