Add page-scoped dark-theme toggle on the home page#921
Open
lavjeetrai wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@EdwardMoyse I have drafted the solution for this. Could you please review it when you have a moment? |
Member
|
Thanks for this - nice idea! |
Contributor
Author
|
Merging this paves the way for us to drop the theme button from the phoenix bar. This directly addresses #903 |
Member
|
Not sure - not all Phoenix clients have the home page though. For example,
https://phoenixatlas.web.cern.ch/PhoenixATLAS/
…On Sun, 7 Jun 2026 at 06:22, Lavjeet Kumar Rai ***@***.***> wrote:
*lavjeetrai* left a comment (HSF/phoenix#921)
<#921 (comment)>
Merging this paves the way for us to drop the theme button from the
phoenix bar. This directly addresses #903
<#903>
—
Reply to this email directly, view it on GitHub
<#921?email_source=notifications&email_token=ABTTQSI2DRYM4V5JUME5Q2346TUZFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRUGE2DAMZQGE4KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4641403018>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTTQSPWVTWFQFDV75A7TU346TUZFAVCNFSM6AAAAACZZNUNJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMNBRGQYDGMBRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change places the existing dark/light theme toggle on the home page only, in the top-right corner.
Changes
Screen.Recording.2026-06-04.034153.mp4