Skip to content

Add page-scoped dark-theme toggle on the home page #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lavjeetrai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add page-scoped dark-theme toggle on the home page #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9178493
added toggle on home page
lavjeetrai Jun 3, 2026
a66440a
Make tooltip more precise
EdwardMoyse Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/phoenix-ng/projects/phoenix-app/src/app/home/home.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<app-dark-theme class="home-theme-toggle"></app-dark-theme>

<div class="container">
<div class="pricing-header p-3 pt-md-5 pb-md-4 text-center">
<img
Expand Down
7 changes: 7 additions & 0 deletions packages/phoenix-ng/projects/phoenix-app/src/app/home/home.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
.home-theme-toggle {
position: fixed;
top: 0.75rem;
right: 0.75rem;
z-index: 10000;
}

h1 {
font-family: 'Circular';
}
Expand Down
9 changes: 7 additions & 2 deletions packages/phoenix-ng/projects/phoenix-ui-components/lib/components/nav/nav.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
<a id="mainLogo" class="main-logo fixed-top p-2 mx-auto mt-2" routerLink="/">
<img src="assets/images/logo-text.svg" />
<a
id="mainLogo"
class="main-logo fixed-top p-2 mx-auto mt-2"
routerLink="/"
aria-label="Phoenix home"
>
<img src="assets/images/logo-text.svg" alt="Phoenix logo" />
</a>
2 changes: 1 addition & 1 deletion ...rojects/phoenix-ui-components/lib/components/ui-menu/dark-theme/dark-theme.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<app-menu-toggle
tooltip="Dark theme"
tooltip="Switch Dark/Light theme"
[active]="darkTheme"
icon="dark"
(click)="setDarkTheme()"
Expand Down
2 changes: 2 additions & 0 deletions ...oenix-ui-components/lib/components/ui-menu/ui-menu-wrapper/ui-menu-wrapper.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<div id="uiMenu">
<button
id="hideUIMenu"
type="button"
aria-label="Toggle toolbar visibility"
[matTooltip]="hideUIMenu ? 'Show toolbar' : 'Hide toolbar'"
matTooltipPosition="above"
(click)="hideUIMenu = !hideUIMenu"
Expand Down
Loading