Explicitly configure ad-hoc codesigning after electron-builder changes#9444
Merged
Merged
Conversation
absidue
requested review from
a user,
MarmadileManteater,
PikachuEXE,
Svallinn and
efb4f5ff-1298-471a-8973-3d47447115dc
July 17, 2026 17:09
github-actions
Bot
added
the
PR: waiting for review
FreeTubeBot
enabled auto-merge (squash)
July 17, 2026 17:09
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 17, 2026
ghost
approved these changes
Jul 17, 2026
github-actions
Bot
removed
the
PR: waiting for review
4 tasks
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
For a while electron-builder was ad-hoc signing by default when no code signing identity was provided but in version 26.15.0 (PR: electron-userland/electron-builder#9822) they stopped doing that and made it an opt-in thing. Without the ad-hoc codesigning macOS refuses to launch saying that the app is broken, with the ad-hoc code signing it still refuses to launch by default but it only complains about not being able to verify the signature which is a lot less alarming to users and easier to bypass (checking boxes in settings GUIs instead of having to remove the quarantine attribute with a command).
The difference in the dialogs that macOS shows can be seen here: electron-userland/electron-builder#9007
Testing
Test build here: https://github.com/absidue/FreeTube/actions/runs/29598510452
As I don't have a macOS machine I haven't been able to test it myself but looking at the code changes on the electron-builder side, this should be enough to get us back to how it was before.
Desktop