Skip to content

Update release workflow to use GH CLI instead of deprecated action#9466

Closed
PikachuEXE wants to merge 2 commits into
FreeTubeApp:developmentfrom
PikachuEXE:ci/gh-release-upload
Closed

Update release workflow to use GH CLI instead of deprecated action#9466
PikachuEXE wants to merge 2 commits into
FreeTubeApp:developmentfrom
PikachuEXE:ci/gh-release-upload

Conversation

@PikachuEXE

Copy link
Copy Markdown
Member

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

This PR includes #9460 so that assets can be tested properly
That PR should be merged first

Description

Spotted deprecation message in last run - https://github.com/FreeTubeApp/FreeTube/actions/runs/29556083929
Found gh release upload - https://github.com/marketplace/actions/publish-release (bottom, example included)
Doc for command & env var:

Screenshots

Build log screenshot (only the changed part
image

Testing

Download assets (all versions, archive and installer) for each OS to see if app can be extracted/installed and run
https://github.com/PikachuEXE/FreeTube/releases/tag/v0.25.0-beta-release-test-202607201605
Assets uploaded by https://github.com/PikachuEXE/FreeTube/actions/runs/29726731446

In addition you might want to test #9444 & #9460

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

Already tested macos x64 + arm64 on m1 mac w/ macOS 15.7.7

absidue and others added 2 commits July 19, 2026 15:52
…ase upload

Release workflow now also only needs tag instead of release ID (hidden inside HTML source code)
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 20, 2026 08:47
@github-actions github-actions Bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 20, 2026
@absidue

absidue commented Jul 20, 2026

Copy link
Copy Markdown
Member

We cannot use the GitHub CLI for this as it uses the wrong mimetypes for the assets and the maintainers have explicitly said that they will not allow the caller to customise the mimetype as they consider that a security risk cli/cli#11795. If you want to get rid of the deprecated action you will need to do it some other way, such as using curl to upload them, I was going to write a bash script to do it with curl so we could get rid of all the boiler plate of defining a separate step for each asset, but I haven't got around to doing that yet.

Additionally please don't use GitHub Actions templating in shell commands, instead set the values as environment variables using env and then use the environment variables in the script. See https://docs.zizmor.sh/audits/#template-injection

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PikachuEXE

Copy link
Copy Markdown
Member Author

You go ahead with bash script coz I have no idea how to get rid of all the boiler plate of defining a separate step for each asset 😅

@PikachuEXE PikachuEXE closed this Jul 21, 2026
auto-merge was automatically disabled July 21, 2026 01:04

Pull request was closed

@PikachuEXE
PikachuEXE deleted the ci/gh-release-upload branch July 22, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants