Skip to content

Adapt EmbodiChain to DexSim 0.6.0rc1 on Python 3.12 - #1124

Merged
yuecideng merged 13 commits into
mainfrom
codex/dexsim-060rc1-py312
Nov 8, 2026
Merged

yuecideng merged 13 commits into
mainfrom
codex/dexsim-060rc1-py312

Conversation

@yuecideng

@yuecideng yuecideng commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Pin dexsim_engine==0.6.0rc1 and adapt EmbodiChain to the released DexSim contracts. The change updates DexUni solver defaults and options, URDF continuous-joint loading, USD material export, renderer teardown, contact solver reports and validity masks, and robot asset lookup. Relevant implementation details were selected from #829 and verified against the installed release wheel.

Run the primary CI jobs on Python 3.12. DexSim 0.6.0rc1 publishes Python 3.11 and 3.12 wheels, so the package minimum is now 3.11 and the Python 3.10 installation matrix is removed. Python 3.11 compatibility coverage remains in the dataset tooling workflow.

The two local Python 3.10 Conda environments were removed as requested; that cleanup is outside this PR.

Dependencies: dexsim_engine==0.6.0rc1 from the configured private package index.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves existing functionality)
  • Breaking change (Python 3.10 installation support is removed)

Validation

  • Python 3.12.16, DexSim 0.6.0rc1, Torch 2.11.0+cu130; pip check passes.
  • Full default unit suite: pytest -q tests/ — 13,308 passed, 592 skipped, 93 deselected. The deselected cases are marked slow by repository configuration; GPU-marked cases are skipped by default and are being run separately.
  • CI and context tests: 185 passed, 4 skipped.
  • Focused solver, loading, rendering, contact, support-observation, Task Program, BrainCo, and raw MuJoCo contact-parameter tests pass.
  • black . and black --check . pass (2,267 files); API docs coverage passes (4,391/4,391 exports); actionlint passes for changed workflows; agent context check and git diff --check pass.
  • Dedicated GPU-marked suite is in progress. Its result will be added here before the PR is marked ready for review.

Coverage additions protect changed solver and contact contracts, native source names, USD degree-to-radian stiffness, and raw MuJoCo parameter lowering. Tests using removed query/capture behavior were updated to the 0.6 contract. Simulation and sensor context was updated; affected robot, visualization, environment, RL, and GenSim context remains accurate.

Checklist

  • I ran black . with the required version 26.10.1.
  • I reviewed affected documentation and agent context and updated obsolete guidance.
  • Public API coverage check passes.
  • I reviewed the necessity of added and extended tests.
  • Dependencies have been updated.
  • Primary full unit suite and CI workflow checks pass.
  • Dedicated GPU suite is complete and reviewed.

Update Newton solver, contact query, USD loading and rendering adapters for the Python 3.12 DexSim release. Align regression coverage and project context with the new contracts.
@yuecideng yuecideng added enhancement Improvements to existing capabilities; use feature for new capabilities. dependencies Dependency versions, upgrades and compatibility. dexsim DexSim SDK interfaces, version adaptation and integration. physics Physics backends, dynamics, contacts, fluids, deformables and physics solvers. sensor Sensor models, attachment, lifecycle, extension interfaces and observation contracts. rendering Image generation, lighting, material rendering, native renderers and image quality. robot Robot runtime, presets, control groups, calibration and robot support. labels Nov 8, 2026
Switch the main workflow and shared Conda activation to py312. Keep the supported Python 3.11 compatibility lane, remove Python 3.10 installation checks, and raise the package minimum to 3.11 because DexSim 0.6.0rc1 has no cp310 wheel.
@yuecideng yuecideng added the ci Continuous integration, build automation and release automation. label Nov 8, 2026
@yuecideng
yuecideng marked this pull request as ready for review November 8, 2026 05:21
@greptile-apps

greptile-apps Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge, with non-blocking feedback about the CI guide and the removed physical-outcome test.

Fix All in CodexFindings

  1. P2 CI guide names wrong Python ▶
  2. P2 Empty scoops go unchecked ▶
Fix with agent prompt
### Issue 1
docker/README.md:193
`docker/README.md` says CI activates `py312`, but the latest change switches both the shared action and the main test job back to `py311`. Contributors following this guide will use a different Python and dependency set from CI. `docker/VALIDATION.md` also still says main CI uses Python 3.12. Update both statements to match the workflows, or restore the intended Python 3.12 jobs.

### Issue 2
tests/sim/test_scoop_ice_demo.py:undefined-114
Removing `test_default_scoops_and_retains_ice` drops the only check that the simulated scoop actually retains ice. The remaining tests use fake objects to check placement and commanded motion, so they still pass if a DexSim change breaks the physical grasp. Keep this slow GPU check, or replace it with an equivalent physical-outcome test.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adapts EmbodiChain to DexSim 0.6.0rc1 and raises the minimum Python version to 3.11.

  • Newton scenes use DexSim’s grouped solver options and updated defaults.
  • Contact sensors read DexSim solver reports and mark measured quantities per row.
  • Robot loading, headless rendering, and USD export follow DexSim’s updated resource paths.
  • Installs require Python 3.11 or newer and CI uses the DexSim 0.6 release.

Reviews (13) · Last reviewed commit: "ci: switch main validation to Python 3.1..." · Reviewed by Greptile

Comment thread pyproject.toml Resolved
Comment thread embodichain/lab/sim/cfg/physics.py Resolved
Remove CI planner and example fallbacks for Python 3.10, update metadata tests, and align user-facing support documentation with the Python 3.11 minimum.
@yuecideng yuecideng added breaking User-visible incompatible changes requiring migration. docs Documentation, API references and example explanations. labels Nov 8, 2026
Regenerate Python 3.11/3.12 Docker locks for DexSim 0.6.0rc1, sync curated architecture evidence, and migrate shipped soft-body demos to grouped DexUni options with per-object contact materials.
Give the Python 3.12 simulation test container a dummy SDL video driver and private runtime directory so DexSim can initialize its native renderer without a display server.
Temporarily hide visual materials from DexSim NoRender native calls, flush deferred simulator cleanup after locomotion subprocesses, and remove the flaky ice retention smoke test as requested.
@@ -112,48 +112,6 @@ def compute_ik(pose, **kwargs):
torch.testing.assert_close(plan(moved_bin, tilted_grasp), moved_bin @ baseline)


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Empty scoops go unchecked

Removing test_default_scoops_and_retains_ice drops the only check that the simulated scoop actually retains ice. The remaining tests use fake objects to check placement and commanded motion, so they still pass if a DexSim change breaks the physical grasp. Keep this slow GPU check, or replace it with an equivalent physical-outcome test.

Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/sim/test_scoop_ice_demo.py
Line: 114

Comment:
**Empty scoops go unchecked**

Removing `test_default_scoops_and_retains_ice` drops the only check that the simulated scoop actually retains ice. The remaining tests use fake objects to check placement and commanded motion, so they still pass if a DexSim change breaks the physical grasp. Keep this slow GPU check, or replace it with an equivalent physical-outcome test.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Codex Fix in Claude Code

Comment thread scripts/ci/run_test_plan.py Resolved
@yuecideng
yuecideng merged commit 460939c into main Nov 8, 2026
14 checks passed
@yuecideng
yuecideng deleted the codex/dexsim-060rc1-py312 branch November 8, 2026 16:57
Comment thread docker/README.md

CI defaults to the published internal `v4-py311-py312` image
and activates `py311`. The image reference and activation command are explicit
and activates `py312`. The image reference and activation command are explicit

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 CI guide names wrong Python

docker/README.md says CI activates py312, but the latest change switches both the shared action and the main test job back to py311. Contributors following this guide will use a different Python and dependency set from CI. docker/VALIDATION.md also still says main CI uses Python 3.12. Update both statements to match the workflows, or restore the intended Python 3.12 jobs.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docker/README.md
Line: 193

Comment:
**CI guide names wrong Python**

`docker/README.md` says CI activates `py312`, but the latest change switches both the shared action and the main test job back to `py311`. Contributors following this guide will use a different Python and dependency set from CI. `docker/VALIDATION.md` also still says main CI uses Python 3.12. Update both statements to match the workflows, or restore the intended Python 3.12 jobs.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking User-visible incompatible changes requiring migration. ci Continuous integration, build automation and release automation. dependencies Dependency versions, upgrades and compatibility. dexsim DexSim SDK interfaces, version adaptation and integration. docs Documentation, API references and example explanations. enhancement Improvements to existing capabilities; use feature for new capabilities. physics Physics backends, dynamics, contacts, fluids, deformables and physics solvers. rendering Image generation, lighting, material rendering, native renderers and image quality. robot Robot runtime, presets, control groups, calibration and robot support. sensor Sensor models, attachment, lifecycle, extension interfaces and observation contracts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant